This repository was archived by the owner on Feb 7, 2019. It is now read-only.
update travis CI and hook code for compatibility with 3.4.0 #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lini
commented
Jan 2, 2018
lini
commented
- before prepare hook updated to handle new structure of platforms/android directory and copy the google-services.json file to the new location
- travis CI updated to use correct bundle build command instead of the old "npm run build-xxx-bundle"
Contributor
Author
zbranzov
reviewed
Jan 3, 2018
.travis.yml
Outdated
| node_js: "6" | ||
| jdk: oraclejdk8 | ||
| script: cd demo && npm run build.plugin && npm i && npm run build-ios-bundle | ||
| script: cd demo && npm run build.plugin && npm i && tns build ios --bundle |
Contributor
There was a problem hiding this comment.
It would be nice if we add --env.uglify preparing the plugin to become verified one
zbranzov
reviewed
Jan 3, 2018
.travis.yml
Outdated
| script: > | ||
| echo { \"project_info\": { \"project_number\": \"424050927453\", \"firebase_url\": \"https://pptest-53916.firebaseio.com\", \"project_id\": \"pptest-53916\", \"storage_bucket\": \"pptest-53916.appspot.com\" }, \"client\": [ { \"client_info\": { \"mobilesdk_app_id\": \"1:424050927453:android:21d2dd8987e1e3d1\", \"android_client_info\": { \"package_name\": \"org.nativescript.ppTest\" } }, \"oauth_client\": [ { \"client_id\": \"424050927453-o7gv6bcmknujjoaaoa5r4d452cutb9jf.apps.googleusercontent.com\", \"client_type\": 3 } ], \"api_key\": [ { \"current_key\": \"AIzaSyDr3fqH7Z8-vhBNpAges_KFTA7oOoylGvU\" } ], \"services\": { \"analytics_service\": { \"status\": 1 }, \"appinvite_service\": { \"status\": 1, \"other_platform_oauth_client\": [] }, \"ads_service\": { \"status\": 2 } } } ], \"configuration_version\": \"1\"} > demo/app/App_Resources/Android/google-services.json && | ||
| cd demo && npm run build.plugin && npm i && npm run build-android-bundle | ||
| cd demo && npm run build.plugin && npm i && tns build android --bundle |
Contributor
There was a problem hiding this comment.
--env.uglify --env.snapshot are nice additions here
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.