Skip to content

Conversation

imax-iva
Copy link
Contributor

No description provided.

@AndrewDryga
Copy link
Member

Hello, @imax-iva! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

lib/jvalid.ex Outdated
file
|> File.read!()
|> Poison.decode!()
|> NExJsonSchema.Schema.resolve()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nested modules could be aliased at the top of the invoking module.

@coveralls
Copy link

coveralls commented May 22, 2018

Coverage Status

Coverage remained the same at 0.0% when pulling b400b83 on imax-iva:replace_poison_with_jason into e67f761 on Nebo15:master.

@AndrewDryga
Copy link
Member

Ebert has finished reviewing this Pull Request and has found:

  • 2 fixed issues! 🎉

You can see more details about this review at https://ebertapp.io/github/Nebo15/jvalid/pulls/1.

@gmile gmile merged commit 614c699 into Nebo15:master May 22, 2018
@gmile gmile self-requested a review May 22, 2018 12:06
@imax-iva imax-iva deleted the replace_poison_with_jason branch May 22, 2018 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants