Got error after update

[hiberabyss]

Description

Have following error message after update neogit plugin:

Neovim version

NVIM v0.9.1
Build type: Release
LuaJIT 2.1.0-beta3

system vimrc file: "$VIM/sysinit.vim"
fall-back for $VIM: "/opt/homebrew/Cellar/neovim/0.9.1/share/nvim"

Run :checkhealth for more info

Operating system and version

macOS 13.4.1 (c)

Steps to reproduce

Open vim, execute :Neogit

Expected behavior

No response

Actual behavior

Have the error message.

Minimal config

vim.cmd([[set runtimepath=$VIMRUNTIME]])
vim.cmd([[set packpath=/tmp/nvim/site]])
local package_root = "/tmp/nvim/site/pack"
local install_path = package_root .. "/packer/start/packer.nvim"
local function load_plugins()
  require("packer").startup({
    {
      "wbthomason/packer.nvim",
      {
        "TimUntersberger/neogit",
        requires = {
          { "nvim-lua/plenary.nvim" },
          { "sindrets/diffview.nvim" },
        },
        config = function()
          print("loaded neogit")
          require("neogit").setup()
        end,
      },
    },
    config = {
      package_root = package_root,
      compile_path = install_path .. "/plugin/packer_compiled.lua",
      display = { non_interactive = true },
    },
  })
end
if vim.fn.isdirectory(install_path) == 0 then
  print("Installing neogit and dependencies.")
  vim.fn.system({ "git", "clone", "--depth=1", "https://github.com/wbthomason/packer.nvim", install_path })
end
load_plugins()
require("packer").sync()

[CKolkey]

That config works fine for me :\

[CKolkey]

Do you have any custom mappings set?

[hiberabyss]

Do you have any custom mappings set?

What kind of mapping may cause the problem?

[PriceHiller]

I know this bug. Let me guesss @hiberabyss you're disabling two or more default maps by doing something like this:

require("neogit").setup({
  mappings = {
    status = {
      ["s"] = "",
      ["b"] = "",
    }
  }
})

#629 contains a fix for it if that's what you're doing.

[hiberabyss]

Still have following error after updating:

Here is my neogit config:

require('neogit').setup{
  integrations = {
    diffview = true,
  },
  mappings = {
    status = {
      ["$"] = "",
      ['b'] = "",
    }
  }
}

[PriceHiller]

@hiberabyss This bug will affect anything on master currently, try using the branch here if you don't want to wait for a fix. That branch may take a bit to get merged as the changes are quite large.

If you want to use that branch though, you'd set those mappings like so:

require('neogit').setup{
  integrations = {
    diffview = true,
  },
  mappings = {
    status = {
      ["CommandHistory"] = "$", -- Replace $ with whatever key you want to bind to
      ["BranchPopup"] = "b", -- Replace b with whatever key you want to bind to
    }
  }
}

[hiberabyss]

Is it possible to split the bug fix into a separate MR and got merged?

[PriceHiller]

The bug fix is more of a consequence of the major refactoring that is occurring in that branch.

The bugfix is the breaking change from that branch in making the mappings set based on the command not the keys.

So unfortunately, it's not exactly viable to split it away.

[hiberabyss]

Make sense. I'll comment the custom mappings temporarily and waiting for the MR to be merged.

Maybe the bug need to be mentioned in the readme to avoid others facing the same problem.

Thanks for your great work! It's really useful.

[PriceHiller]

@hiberabyss The latest changes on master should work with your bindings now.

#659 was merged resolving issues related to this. To disable mappings with the new changes just set the key you want unbound to false.

[hiberabyss]

It works. Thanks!

[PriceHiller]

Thanks @ten3roberts 😉