Allow configuring log level with strings #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example: SENTRY_LOG_LEVEL=ERROR, etc.
Tethik
suggested changes
Mar 16, 2018
| 'is_local': os.environ.get('IS_OFFLINE', False) or os.environ.get('IS_LOCAL', False), | ||
| 'logging': boolval(os.environ.get('SENTRY_CAPTURE_LOGS', True)), | ||
| 'log_level': int(os.environ.get('SENTRY_LOG_LEVEL', logging.WARNING)), | ||
| 'log_level': extract_log_level_from_environment('SENTRY_LOG_LEVEL', logging.WARNING), |
There was a problem hiding this comment.
Simpler way which doesnt require a new function:
log_levels.get(os.environ.get('SENTRY_LOG_LEVEL'), logging.WARNING)There was a problem hiding this comment.
That would work for the new use case but doesn't preserve backwards compatibility (setting SENTRY_LOG_LEVEL to a numeric value).
|
@trptcolin : Great PR 👍 Can you bump up the version number in: https://github.com/Netflix-Skunkworks/raven-python-lambda/blob/master/raven_python_lambda/__about__.py#L12, and I will then merge and push the new release to PyPI. |
|
0.1.7 uploaded to PyPI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example:
SENTRY_LOG_LEVEL=ERROR, etc.Per discussion on #21
I did preserve the existing behavior (e.g.
SENTRY_LOG_LEVEL=40) to avoid breaking API changes, and I also added some tests around most of the current defaults.