Skip to content

hystrixtimer add removeOnCancelPolicy for ScheduledThreadPoolExecutor to void memory leak #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

hystrixtimer add removeOnCancelPolicy for ScheduledThreadPoolExecutor to void memory leak #1999

wants to merge 7 commits into from

Conversation

lovingcodesk
Copy link

fix #1998

@lovingcodesk
Copy link
Author

I only modify one line code ,but fix some times for travis configuration

@tweimer
Copy link

tweimer commented Sep 6, 2020

Apart from the travis configuration change, it is a duplicate of #1976.

@lovingcodesk
Copy link
Author

lovingcodesk commented Dec 2, 2020 •
edited
Loading

Apart from the travis configuration change, it is a duplicate of #1976.
before #1976,i had commit pr some times ,those times travis configuration always had problem,so I delete them, only this time I passed

tata406
tata406 approved these changes Feb 7, 2021
View reviewed changes
Copy link

@tata406 tata406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@abrahamcuenca abrahamcuenca abrahamcuenca approved these changes

@tata406 tata406 tata406 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

HystrixTimer when it initialize ScheduledThreadPoolExecutor does not set RemoveOnCancelPolicy for true

4 participants

@lovingcodesk @tweimer @abrahamcuenca @tata406