Why are data fetchers returning CompletionStage or CompletableFuture not enabled for instrumentation by default?
#1114
Unanswered
arichardson175
asked this question in
Q&A
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Our team recently noticed some data fetchers returning
CompletableFuturetypes were not emitting metrics likegql.resolver.95percentile, and came across the following code inDgsSchemaProvider:We were able to get the metrics back by explicitly adding
@DgsEnableDataFetcherInstrumentationto our data fetchers, but were wondering: why are metrics disabled by default for these return types? Is there anything we should watch out for when using@DgsEnableDataFetcherInstrumentationhere?Beta Was this translation helpful? Give feedback.
All reactions