Fix Riemannian potato tutorial plot behavior#1011
Merged
bruAristimunha merged 12 commits intodevelopfrom Mar 3, 2026
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
- handle Potato/PotatoField predict label encodings robustly\n- align 2D potato plot with pyRiemann-style offline calibration and clearer channels\n- clarify RPF combined-score wording for dependent p-values
bruaris
force-pushed
the
fix/issue-997-potato-plot
branch
from
37e876b to
65d1505
Compare
Use pyRiemann PR423 capabilities (per-potato metric and custom method_combination) to replace manual iRPF combination logic, and point pyriemann dependency to GitHub source for the new API.
qbarthelemy
reviewed
Mar 2, 2026
examples/advanced_examples/plot_riemannian_artifact_rejection.py
Outdated
Show resolved
Hide resolved
examples/advanced_examples/plot_riemannian_artifact_rejection.py
Outdated
Show resolved
Hide resolved
examples/advanced_examples/plot_riemannian_artifact_rejection.py
Outdated
Show resolved
Hide resolved
examples/advanced_examples/plot_riemannian_artifact_rejection.py
Outdated
Show resolved
Hide resolved
examples/advanced_examples/plot_riemannian_artifact_rejection.py
Outdated
Show resolved
Hide resolved
examples/advanced_examples/plot_riemannian_artifact_rejection.py
Outdated
Show resolved
Hide resolved
bruAristimunha
commented
Mar 2, 2026
examples/advanced_examples/plot_riemannian_artifact_rejection.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com> Signed-off-by: Bru <b.aristimunha@gmail.com>
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com> Signed-off-by: Bru <b.aristimunha@gmail.com>
Signed-off-by: Bru <b.aristimunha@gmail.com>
Rename all 5 call sites from _predict_clean_mask to predict_clean_mask to match the function definition on line 111.
Contributor
|
Can you share here the corrected potato plot? |
Collaborator
Author
qbarthelemy
reviewed
Mar 2, 2026
examples/advanced_examples/plot_riemannian_artifact_rejection.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com> Signed-off-by: Bru <b.aristimunha@gmail.com>
…ontours Replace dense 20-level contourf across the entire z-score map with a two-layer strategy: filled contours masked to inside the potato (z<=3), sparse dashed grey outline contours outside, and a prominent black boundary line. This makes the potato boundary much easier to distinguish.
qbarthelemy
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Potato/PotatoFieldprediction label encodings robustly via_predict_clean_maskPotatoField:metric=[...]method_combinationformin(Fisher, Stouffer)pyriemanndependency to GitHub source (master) to include the new APIFixes #997
Validation
python -m py_compile examples/advanced_examples/plot_riemannian_artifact_rejection.pytomllibparse check forpyproject.toml