Skip to content

Conversation

@planetabhi
Copy link
Member

@planetabhi planetabhi commented Oct 31, 2025

Summary by CodeRabbit

  • Chores

    • Updated package versions for core and colors libraries
  • Style

    • Restructured theme color token system across all theme variants
    • Refined color values for light, dark, warm, and cold themes
    • Improved color variable organization for better consistency

@coderabbitai
Copy link

coderabbitai bot commented Oct 31, 2025

Walkthrough

This PR updates package versions and refactors CSS custom properties across all color theme files. The root package.json is bumped to 0.3.1, the colors package to 2.2.0, icon tokens are removed, text tokens are systematically renamed to content tokens, and border-muted references are adjusted across dark and light theme variants.

Changes

Cohort / File(s) Summary
Root and package manifests
package.json, packages/colors/package.json
Version bumps: root 0.3.0 → 0.3.1; colors 2.1.0 → 2.2.0
Dark theme tokens
packages/colors/src/_theme-dark.scss, packages/colors/src/_theme-dark--cold.scss, packages/colors/src/_theme-dark--warm.scss
Removed --icon-\* tokens; renamed --text-\* to --content-\*; updated --border-muted from --grey9/--cold9/--warm9 to --grey8/--cold8/--warm8
Light theme tokens
packages/colors/src/_theme-light.scss, packages/colors/src/_theme-light--cold.scss, packages/colors/src/_theme-light--warm.scss
Removed --icon-\* tokens; renamed --text-\* to --content-\*; updated --border-muted from --grey2/--cold2/--warm2 to --grey3/--cold3/--warm3

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

  • Verify all six theme files follow the identical token-rename pattern (--text-primary → --content-primary, etc.)
  • Confirm --border-muted updates are semantically correct for each theme variant
  • Check that all --icon-\* token removals are consistent across all files

Possibly related PRs

  • feat: color updates #10: Modifies the same colors package and theme SCSS files with related color token adjustments.
  • feat: vb #11: Updates @new-ui/colors package versioning constraints alongside the colors package version bump in this PR.

Poem

🐰 With whiskers twitched and hop-skip glee,
We hop from text to content spree,
Icons fade, borders shift their tone,
New tokens born, old names now gone!
Hop, hop—design refreshed, well-done!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Title Check ❓ Inconclusive The pull request title is "is," which is a single generic word that does not convey any meaningful information about the changeset. The changeset involves significant CSS theme variable refactoring (renaming text-related variables to content-related variables, removing icon variables, updating border tokens) and version bumps across multiple files. The title fails to describe any aspect of these changes and does not help a teammate scanning history understand the primary purpose of the pull request. The title should be replaced with a clear, descriptive single sentence that summarizes the main change. A suitable title might be something like "Refactor CSS theme variables: rename text tokens to content and remove icon tokens" to clearly communicate the primary refactoring work being performed across the theme files.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ff85850 and 5063329.

⛔ Files ignored due to path filters (4)
  • bun.lock is excluded by !**/*.lock
  • packages/colors/bun.lock is excluded by !**/*.lock
  • packages/colors/dist/index.css is excluded by !**/dist/**
  • packages/colors/dist/index.css.map is excluded by !**/dist/**, !**/*.map
📒 Files selected for processing (8)
  • package.json (1 hunks)
  • packages/colors/package.json (1 hunks)
  • packages/colors/src/_theme-dark--cold.scss (2 hunks)
  • packages/colors/src/_theme-dark--warm.scss (2 hunks)
  • packages/colors/src/_theme-dark.scss (2 hunks)
  • packages/colors/src/_theme-light--cold.scss (2 hunks)
  • packages/colors/src/_theme-light--warm.scss (2 hunks)
  • packages/colors/src/_theme-light.scss (2 hunks)
🔇 Additional comments (13)
packages/colors/package.json (1)

3-3: Version bump looks appropriate.

The minor version bump from 2.1.0 to 2.2.0 is justified given the token refactoring (content tokens added, icon tokens removed). However, verify that the root package.json dependency on this package is updated accordingly.

packages/colors/src/_theme-light.scss (2)

133-133: Border-muted adjustment is reasonable.

Changing from var(--grey2) to var(--grey3) provides better visibility for borders in the light theme. This aligns with typical design system practices where secondary UI elements need sufficient contrast.


158-166: Text→Content token rename is consistent with PR refactoring.

The systematic renaming of --text-* tokens to --content-* tokens is applied uniformly across all content-related tokens. The mappings are preserved (e.g., primary still maps to var(--grey10)), ensuring no functional change to rendered output.

packages/colors/src/_theme-light--cold.scss (2)

144-144: Border-muted adjusted consistently with cold variant.

Changing to var(--cold3) aligns with the light-cold theme's color progression and maintains visibility. The change mirrors the adjustment made in the base light theme.


169-177: Content tokens properly mapped to cold variant values.

Token remapping maintains semantic meaning while using the cold-variant color palette (cold10→primary, cold7→secondary, etc.). No functional issues detected.

packages/colors/src/_theme-light--warm.scss (2)

144-144: Border-muted adjusted consistently with warm variant.

Changing to var(--warm3) follows the pattern seen in other light theme variants, improving border visibility within the warm color palette.


169-177: Content tokens properly mapped to warm variant values.

Token mappings preserve semantic meaning while using warm-variant colors. Consistent with light theme refactoring.

packages/colors/src/_theme-dark--warm.scss (2)

144-144: Border-muted adjusted to maintain visibility in dark theme.

Changing from var(--warm9) to var(--warm8) provides better contrast in the dark theme (where lower indices are lighter). This maintains the visibility principle across all theme variants.


169-177: Content tokens properly inverted for dark theme.

Token mappings are correctly inverted for dark theme context (warm1→primary for light text, warm4→secondary, etc.). Semantic meaning is preserved while adapting to dark backgrounds.

packages/colors/src/_theme-dark--cold.scss (2)

144-144: Border-muted adjusted consistently with dark-cold variant.

Changing to var(--cold8) maintains visibility in the dark-cold theme, following the same adjustment pattern as dark-warm.


169-177: Content tokens properly mapped to dark-cold variant values.

Token mappings follow the established dark theme inversion pattern with cold-variant colors. No issues detected.

packages/colors/src/_theme-dark.scss (2)

133-133: Border-muted adjustment improves dark theme border visibility.

Changing from var(--grey9) to var(--grey8) provides better contrast for borders in the dark theme. This aligns with the adjustment pattern seen in all other theme variants.


158-166: Base dark theme content tokens properly remapped.

The text→content token rename is applied uniformly with appropriate inverted mappings for dark backgrounds (grey1→primary for light text on dark, grey4→secondary, etc.). Refactoring is complete and consistent.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@planetabhi planetabhi merged commit c6dc825 into main Oct 31, 2025
1 check passed
@coderabbitai coderabbitai bot mentioned this pull request Oct 31, 2025
Merged
@coderabbitai coderabbitai bot mentioned this pull request Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants