Skip to content

Conversation

@ksstott
Copy link
Member

@ksstott ksstott commented Dec 29, 2019

Fixes #5

Copy link
Contributor

@Jameskmonger Jameskmonger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :)

@Jameskmonger
Copy link
Contributor

although @ksstott you may want to just return early from that function if this.container is null, to prevent needlessly rendering to a canvas

@ksstott
Copy link
Member Author

ksstott commented Dec 31, 2019

although @ksstott you may want to just return early from that function if this.container is null, to prevent needlessly rendering to a canvas

It's more complicated than that though. this.container only becomes null after the await. Unless I've misunderstood what you meant.

@Jameskmonger
Copy link
Contributor

It's more complicated than that though. this.container only becomes null after the await. Unless I've misunderstood what you meant.

weird! good catch

Copy link

@bartlomiejzuber bartlomiejzuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hisuwh
Copy link

hisuwh commented Jan 22, 2020

@ksstott if I merge this do you think you can look at publishing it? Do you have an npm account?

@ksstott
Copy link
Member Author

ksstott commented Jan 23, 2020

@ksstott if I merge this do you think you can look at publishing it? Do you have an npm account?

@hisuwh Yes I can do that.
no, someone will need to show me/give me access to publishing to npm please

@hisuwh hisuwh merged commit f3a39f3 into master Jan 23, 2020
@hisuwh hisuwh deleted the issue/undefined-container branch January 23, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'appendChild' of null

5 participants