Skip to content

Conversation

@rackstar
Copy link
Contributor

@rackstar rackstar commented Jul 28, 2025

Description

  • fix submitClaim
  • add ClaimAlreadyPaidOut error on submitClaim
  • add Claims.depositRetrieved field
  • add isAssessor viewer
  • add retrieveDeposit unit tests

Testing

  • unit tests

Checklist

  • Performed a self-review of my own code
  • Made corresponding changes to the documentation

@rackstar rackstar requested a review from duxxud July 28, 2025 21:11
@rackstar rackstar self-assigned this Jul 28, 2025
@rackstar rackstar changed the title fix: fix submitClaims + add removeFromAssessorGroupsAndWhiteList fix: fix submitClaims + add Claims.depositRetrieved field Jul 30, 2025
@rackstar rackstar force-pushed the feat/permissioned-assessment-claims-leftovers branch from b26ee34 to 46b7ac0 Compare July 30, 2025 03:24
@rackstar rackstar force-pushed the feat/permissioned-assessment-claims-leftovers branch from 3c3c95b to 49cc157 Compare July 30, 2025 15:20
@rackstar
Copy link
Contributor Author

the "non-assessor" require in TC.removeFromWhitelist will be added by @MilGard91 when he adds the registry dependency to TC:

  function removeFromWhitelist(address _member) public override onlyInternal {
  
    require(token.balanceOf(_member) == 0, MemberBalanceNotZero());
    
    uint memberId = registry.getMemberId(_member);
    require(!assessment().isAssessor(memberId), MustNotBeAssessorToLeave());
    
    token.removeFromWhiteList(_member);
  }

@rackstar rackstar force-pushed the feat/permissioned-assessment-claims-leftovers branch from d1b48a9 to 49cc157 Compare August 1, 2025 01:56
@rackstar rackstar moved this from ⚖ Backlog to 👀 In review in Engineering Tracker 💻 Aug 1, 2025
Copy link
Contributor

@shark0der shark0der left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@github-project-automation github-project-automation bot moved this from 👀 In review to 🏗 In progress in Engineering Tracker 💻 Aug 6, 2025
@rackstar rackstar force-pushed the feat/permissioned-assessment-claims-leftovers branch from 0c3297d to 7e658bb Compare August 6, 2025 14:49
@rackstar rackstar force-pushed the feat/permissioned-assessment-claims-leftovers branch from 7e658bb to 046e57c Compare August 6, 2025 14:51
@rackstar rackstar merged commit 4f60bb8 into breaking/v3 Aug 6, 2025
2 of 4 checks passed
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Engineering Tracker 💻 Aug 6, 2025
@rackstar rackstar deleted the feat/permissioned-assessment-claims-leftovers branch August 6, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants