-
Notifications
You must be signed in to change notification settings - Fork 66
fix: fix submitClaims + add Claims.depositRetrieved field #1402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rackstar
merged 18 commits into
breaking/v3
from
feat/permissioned-assessment-claims-leftovers
Aug 6, 2025
Merged
fix: fix submitClaims + add Claims.depositRetrieved field #1402
rackstar
merged 18 commits into
breaking/v3
from
feat/permissioned-assessment-claims-leftovers
Aug 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rackstar
commented
Jul 28, 2025
rackstar
commented
Jul 28, 2025
shark0der
reviewed
Jul 29, 2025
shark0der
reviewed
Jul 29, 2025
* require payout redemption period to apply only for redeemClaimPayout * add DepositAlreadyRetrieved error to retrieveDeposit
* add claim struct unit tests
* removeFromWhitelist * switchMembershipAddressWithTransfer
b26ee34 to
46b7ac0
Compare
3c3c95b to
49cc157
Compare
|
the "non-assessor" require in function removeFromWhitelist(address _member) public override onlyInternal {
require(token.balanceOf(_member) == 0, MemberBalanceNotZero());
uint memberId = registry.getMemberId(_member);
require(!assessment().isAssessor(memberId), MustNotBeAssessorToLeave());
token.removeFromWhiteList(_member);
} |
d1b48a9 to
49cc157
Compare
duxxud
reviewed
Aug 4, 2025
shark0der
reviewed
Aug 6, 2025
shark0der
reviewed
Aug 6, 2025
shark0der
reviewed
Aug 6, 2025
shark0der
reviewed
Aug 6, 2025
shark0der
reviewed
Aug 6, 2025
shark0der
requested changes
Aug 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
duxxud
approved these changes
Aug 6, 2025
0c3297d to
7e658bb
Compare
7e658bb to
046e57c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
Checklist