profile: suggest removal using profile entry name #10060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a file conflict arises during a package install a suggestion is made to remove the old entry. This was previously done using the installable URLs of the old entry. These URLs are quite verbose and often do not equal the URL of the existing entry. This change uses the recently introduced profile entry name for the suggestion, resulting in a simpler output. The improvement is easily seen in the change to the functional test.
github-actions
bot
added
new-cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When a file conflict arises during a package install a suggestion is made to remove the old entry. This was previously done using the installable URLs of the old entry. These (resolved) URLs are quite verbose and often do not match the source URL of the existing entry (see #8728).
This change uses the recently introduced profile entry name for the suggestion (see #9656), resulting in a simpler output.
The improvement is easily seen in the change to the functional test.
Context
Fixes #8728
As mentioned: #7967 (comment)
Follow up from #9656
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.