Restore an accidentally suppressed negation #4828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accidentally removed in ca96f52. This caused `nix run` to systematically fail with ``` error: app program '/nix/store/…' is not in the Nix store ```
|
Perhaps time to add a simple run invocation to the tests? |
As a matter of fact, there is one, and it caught this all right. The problem (at least on my side) is #3605 which tends to make me ignore unexpected CI failures as “oh nvm, that’s the flaky darwin test striking again” (which is pretty stupid I guess, but…) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accidentally removed in ca96f52. This caused
nix runto systematically fail with