Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port nix.sh to the fish shell #626

Closed
wants to merge 1 commit into from
Closed

Conversation

@tchajed
Copy link

tchajed commented Aug 28, 2015

Sourcing nix.sh won't work on fish shell since it doesn't use the same syntax. This patch adds a new nix.fish that can be sourced from fish.

@domenkozar
Copy link
Member

domenkozar commented Oct 8, 2015

I've seen requests for this, it's going to be pain to maintain (we'd need a test).

@Ericson2314
Copy link
Member

Ericson2314 commented Oct 17, 2015

@domenkozar Hmm? I think it would be pretty popular and thus less likely to rot. But what tests were you thinking of?

@domenkozar
Copy link
Member

domenkozar commented Jun 3, 2016

@tchajed could you rebase and sync with recent changes? I don't see why we shouldn't support this as long as it's maintained.

@yacinehmito
Copy link

yacinehmito commented Sep 24, 2016

@tchajed What is the status on this please ? I would be happy to help.

@tchajed tchajed force-pushed the tchajed:fish-profile branch from 690bc0b to 0322562 Sep 25, 2016
@tchajed
Copy link
Author

tchajed commented Sep 25, 2016

It looks like the sh profile has become more complicated. While I fixed merge conflicts, the new profile needs to be translated to fish again. I'm not able to get nix to compile, and since I don't actually use it I'd rather pass this on to someone who will maintain it.

@gpyh: feel free to use this as a starting point and create your own pull request! I'd rather not submit code I haven't tested.

@nhooyr
Copy link

nhooyr commented Oct 12, 2016

I'm gonna try and work on this in a new PR.

@pickfire
Copy link

pickfire commented May 11, 2020

Any news on this?

@tchajed
Copy link
Author

tchajed commented May 11, 2020

I'm closing in favor of the latest attempt by @asymmetric in #1090, which hopefully gets resolved and merged.

@tchajed tchajed closed this May 11, 2020
@pickfire
Copy link

pickfire commented May 12, 2020

@tchajed @asymmetric issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.