Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oberon-risc-emu: init at 2020-08-18 #100042

Merged
merged 1 commit into from
Jan 10, 2021
Merged

oberon-risc-emu: init at 2020-08-18 #100042

merged 1 commit into from
Jan 10, 2021

Conversation

siraben
Copy link
Member

@siraben siraben commented Oct 8, 2020 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

IvarWithoutBones
IvarWithoutBones requested changes Oct 8, 2020
View reviewed changes
Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions, but functionality wise this PR LGTM 👍

Binary builds, and successfully displays the help section.

Result of nixpkgs-review pr 100042 1

1 package built:
  • oberon-risc-emu

pkgs/misc/emulators/oberon-risc-emu/default.nix Show resolved Hide resolved
pkgs/misc/emulators/oberon-risc-emu/default.nix Show resolved Hide resolved
@siraben siraben mentioned this pull request Oct 9, 2020
Closed
@siraben siraben force-pushed the oberon-risc-emu-init branch 2 times, most recently from 92119b8 to 006b656 Compare October 9, 2020 03:52
@siraben siraben changed the title oberon-risc-emu: init at unstable-2020-08-18 oberon-risc-emu: init at 2020-08-18 Oct 9, 2020
@siraben
Copy link
Member Author

siraben commented Oct 10, 2020

@GrahamcOfBorg eval

@siraben siraben force-pushed the oberon-risc-emu-init branch 2 times, most recently from 1e1b758 to d0fd082 Compare November 27, 2020 03:06
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 100042 run on x86_64-linux 1

1 package built:
  • oberon-risc-emu

@SuperSandro2000 SuperSandro2000 merged commit be660e2 into NixOS:master Jan 10, 2021
@siraben siraben deleted the oberon-risc-emu-init branch January 10, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvarWithoutBones IvarWithoutBones IvarWithoutBones requested changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siraben @SuperSandro2000 @IvarWithoutBones