Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-synapse: 1.33.2 -> 1.34.0 #123355

Merged
merged 2 commits into from
May 19, 2021
Merged

matrix-synapse: 1.33.2 -> 1.34.0 #123355

merged 2 commits into from
May 19, 2021

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented May 17, 2021

Motivation for this change

ChangeLog: https://github.com/matrix-org/synapse/releases/tag/v1.34.0

The removal of room_invite_state_types shouldn't be backported btw. I confirmed that matrix-synapse 1.34 works both with and without this change.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label May 17, 2021
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels May 17, 2021
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels May 17, 2021
sumnerevans
sumnerevans approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@sumnerevans sumnerevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am running Synapse 1.34.0 without the room_invite_state_types depreciation patch. It's working well.

@mweinelt mweinelt merged commit 446c97f into NixOS:master May 19, 2021
@mweinelt mweinelt mentioned this pull request May 19, 2021
Merged
10 tasks
@Ma27 Ma27 deleted the bump-matrix-synapse branch May 19, 2021 16:47
@sumnerevans sumnerevans mentioned this pull request May 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumnerevans sumnerevans sumnerevans approved these changes

@fadenb fadenb fadenb approved these changes

@mguentner mguentner Awaiting requested review from mguentner

@mjlbach mjlbach Awaiting requested review from mjlbach

@Ralith Ralith Awaiting requested review from Ralith

@pacien pacien Awaiting requested review from pacien

@Ekleog Ekleog Awaiting requested review from Ekleog

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ma27 @fadenb @sumnerevans @mweinelt