Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability Roundup 18 #21967

Closed
36 of 38 tasks
grahamc opened this issue Jan 18, 2017 · 24 comments
Closed
36 of 38 tasks

Vulnerability Roundup 18 #21967

grahamc opened this issue Jan 18, 2017 · 24 comments
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one

Comments

@grahamc
Copy link
Member

grahamc commented Jan 18, 2017

Here are all the vulnerabilities from https://lwn.net/Vulnerabilities
since our last roundup.

cc: @fpletz @FRidh @Mic92 @7c6f434c @LnL7 @bachp .

Note: The list of people CC'd on this issue participated in the last
roundup. If you participate on this roundup, I'll cc you on the next
one. If you don't participate in the next one, you won't be CC'd on
the one after that. If you would like to be CC'd on the next roundup,
add a comment to the most recent vulnerability roundup.

Permanent CC's: @joepie91, @phanimahesh, @the-kenny,
@NixOS/security-notifications
If you would like to be CC'd on all roundups (or removed from the
list), open a PR editing
https://github.com/NixOS/security/blob/master/lwnvulns/src/bin/instructions.md.

Notes on the list

  1. The reports have been roughly grouped by the package name. This
    isn't perfect, but is intended to help identify if a whole group
    of reports is resolved already.
  2. Some issues will be duplicated, because it affects multiple
    packages. For example, there are sometimes problems that impact
    thunderbird, and firefox. LWN might report in one vulnerability
    "thunderbird firefox". These names have been split to make sure
    both packages get addressed.
  3. By each issue is a link to code search for the package name, and
    a Github search by filename. These are to help, but may not return
    results when we do in fact package the software. If a search
    doesn't turn up, please try altering the search criteria or
    looking in nixpkgs manually before asserting we don't have it.
  4. This issue is created by https://github.com/NixOS/security

Instructions:

  1. Triage a report: If we don't have the software or our version isn't
    vulnerable, tick the box or add a comment with the report number,
    stating it isn't vulnerable.
  2. Fix the issue: If we do have the software and it is vulnerable,
    either leave a comment on this issue saying so, even open a pull
    request with the fix. If you open a PR, make sure to tag this
    issue so we can coordinate.
  3. When an entire section is completed, move the section to the
    "Triaged and Resolved Issues" details block below.

Upon Completion ...

Without further ado...

Assorted (32 issues)

pgbouncer (2 issues)

@grahamc grahamc added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Jan 18, 2017
@grahamc grahamc mentioned this issue Jan 18, 2017
28 tasks
@vcunat
Copy link
Member

vcunat commented Jan 18, 2017

Our libX11 is not vulnerable. According to the Debian commit the problem was introduced after 1.6.4 release as an incorrect attempt to fix a memory leak. So, our version may only leak memory. I'd personally wait for a release for this one.

@the-kenny
Copy link
Contributor

Our simgear doesn't seem to be vulnerable either: The Fedora alert is about 2016.3.1 and we're on 2016.4.3.

I'll push an update to 2016.4.4 in a few hours.

vcunat added a commit that referenced this issue Jan 18, 2017
@7c6f434c
Copy link
Member

libgit2: we have a fresh enough version

@globin
Copy link
Member

globin commented Jan 18, 2017

libupnp: 3be6e9f (not related to this roundup)

@NeQuissimus
Copy link
Member

We have Docker 1.12.6, which closes the vulnerability mentioned

@vcunat
Copy link
Member

vcunat commented Jan 18, 2017

gnutls: their advisories possibly imply that 3.4 branch is no longer maintained at this point, though I see no explicit saying of that. In any case, master and 16.09 have 3.4 as the default which was last updated on Dec 08 upstream.

@bachp
Copy link
Member

bachp commented Jan 18, 2017

Does someone have an idea how to handle the ark issues? Do we need to update all of KDE?

@bachp
Copy link
Member

bachp commented Jan 18, 2017

Actually I think the ark issue is already fixed in 7d01fff

@grahamc
Copy link
Member Author

grahamc commented Jan 19, 2017

Thanks for the research and looking y'all did today. I wasn't able to do very much due to working on secret side projects, but am carving out some time now.

@grahamc
Copy link
Member Author

grahamc commented Jan 19, 2017

  • Ikiwiki needs patching to 3.20170111 with backport

vcunat pushed a commit that referenced this issue Jan 19, 2017
Fixes the following security issues:

  * CVE-2017-5334
  * CVE-2017-5335
  * CVE-2017-5336
  * CVE-2017-5337

See https://www.gnutls.org/news.html#2017-01-09 for more information.

(cherry picked from commit 85ac790)
/cc #21967.
vcunat added a commit that referenced this issue Jan 19, 2017
@7c6f434c
Copy link
Member

ikiwiki: done

@vcunat
Copy link
Member

vcunat commented Jan 19, 2017

libtiff: took all patches from Debian, on both active branches.

@grahamc
Copy link
Member Author

grahamc commented Jan 19, 2017

pdns: fixed in 1fe5134 (for notes later)

@grahamc
Copy link
Member Author

grahamc commented Jan 20, 2017

Bind addressed in 2fd0a9f and 7b34209 (thank you, @peti)

@grahamc
Copy link
Member Author

grahamc commented Jan 20, 2017

@bachp I suspect we need to fix ark on 16.09. Can you check in to that?

7c6f434c added a commit to 7c6f434c/nixpkgs that referenced this issue Jan 20, 2017
@NixOS/security-notifications (for all three updates)

Relevant to NixOS#21967
@7c6f434c
Copy link
Member

php security update ported to stable, except the php71 part which is not relevant there.

@nlewo
Copy link
Member

nlewo commented Jan 20, 2017

#22001 fixes all qemu CVEs mentionned above excepted CVE-2016-9908 because vulnerable code is not present in our qemu version.

We should definitely upgrade our qemu version as initiated by @7c6f434c with the 2.8 version.

@7c6f434c
Copy link
Member

@nlewo thanks

@grahamc I cherry-picked to stable, but I used the merge commit; not sure if I should have picked one-by-one

Re: qemu_28: NixPkgs-wise it is a no-brainer; NixOS tests need to be re-checked by people actually using NixOS and its tests, I guess.

@grahamc
Copy link
Member Author

grahamc commented Jan 20, 2017

Amazing, @nlewo, thank you so much! How did you find the patches?

@7c6f434c Nice! Extremely timely on those, thank you! Usually I pick one by one, but this should be fine :)

I'll see about running tests with qemu_28.

@nlewo
Copy link
Member

nlewo commented Jan 20, 2017

@7c6f434c There are some tests that are declared in nixos/release.nix but I don't know if the CI executes them. I'm responsible of two of them and I'll try to run them with qemu 2.8.

@grahamc By reading mails associated to the CVE desc on http://cve.mitre.org. I also get some information from https://security-tracker.debian.org (which is really nice).

@grahamc
Copy link
Member Author

grahamc commented Jan 20, 2017

@nlewo if you submit a PR changing the default to 2.8, I can easily run the tests.

@bachp
Copy link
Member

bachp commented Jan 20, 2017

@grahamc I will try if I can backport the patch. I think it is this one here: KDE/ark@82fdfd2

@grahamc
Copy link
Member Author

grahamc commented Jan 21, 2017

Special thank you to @nlewo and @bachp for getting those more annoying ones (IMO...) done, @7c6f434c for merging and cherry-picking commits, @vcunat for finding like a million patches that we were missing on debian ...! @the-kenny for so quickly triaging the flight package, @globin for tagging his libupnp patch despite being in this issue (very useful for making sure it gets in the notices) and @NeQuissimus, and any other anonymous triagers out there!

@grahamc grahamc closed this as completed Jan 21, 2017
@fpletz
Copy link
Member

fpletz commented Jan 21, 2017

@grahamc Last minute fix for libopus: 140d135

vcunat added a commit that referenced this issue Jan 24, 2017
@grahamc grahamc mentioned this issue Jan 25, 2017
34 tasks
adrianpk added a commit to adrianpk/nixpkgs that referenced this issue May 31, 2024
Fixes the following security issues:

  * CVE-2017-5334
  * CVE-2017-5335
  * CVE-2017-5336
  * CVE-2017-5337

See https://www.gnutls.org/news.html#2017-01-09 for more information.

(cherry picked from commit 85ac790)
/cc NixOS#21967.
adrianpk added a commit to adrianpk/nixpkgs that referenced this issue May 31, 2024
adrianpk added a commit to adrianpk/nixpkgs that referenced this issue May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one
Projects
None yet
Development

No branches or pull requests

9 participants