doc: add a note about automatic maven upgrades #238774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is motivated by NixOS#238746
|
@wegank I'm still new here and there is no reviewer or assignee assigned automatically. Since you've been working on Maven lately, maybe you can have a look? |
wegank
approved these changes
Jun 20, 2023
This was referenced Jun 20, 2023
This was referenced Jun 20, 2023
wegank
changed the title
mitchmindtree
pushed a commit
to mitchmindtree/nixpkgs
that referenced
this pull request
Jul 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is motivated by #238746
When upgrading maven, we had to update the hashes of the first invocation of the double invocation methods of packaging maven projects. This was caused by the implicit versions of maven plugins changing with the Maven upgrade. This is not an issue when the versions of all relevant plugins are explicitly set in the Maven project.
I added the section below to the docs so that hopefully this will be less of an issue in the future.
I will approach the upstream devs of existing packages and ask them to explicitly set the versions of the plugins.