Enforce explicit plugin versions#3301
Merged
kevlahnota merged 1 commit intoCard-Forge:masterfrom Jun 24, 2023
Merged
Conversation
Contributor
|
This change seems to work fine, I tested it on my Linux dev workflow (running Linux Mint 21.1). Haven't noticed anything off when compiling via Maven. Anyone else willing to run some tests? (esp. on other systems) |
kevlahnota
approved these changes
Jun 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I recently bumped the Maven version in Nixpgks (NixOS/nixpkgs#238746) and ran into some small but annoying manual effort w.r.t. the
forge-mtgpackage. The issue is thatforge-mtgis packaged using the double invocation method which unfortunately breaks if not all maven plugin versions are set explicitly.We're extending the documentation to prevent this (NixOS/nixpkgs#238774), but I'm reaching out to fix the packages which have already been packaged. In this PR, we explicitly set the versions of the only two plugins which hadn't been set explicitly before and add a check with the enforcer plugin to make sure this won't accidentally break in the future.
I took the liberty of deduplicating the configuration of the enforcer plugin, since this was already causing inconsistencies (
requireMavenVersion).