Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

substituteAll should fail if you pass in uppercase variables #28086

Open
copumpkin opened this issue Aug 9, 2017 · 1 comment
Open

substituteAll should fail if you pass in uppercase variables #28086

copumpkin opened this issue Aug 9, 2017 · 1 comment
Labels
0.kind: enhancement Add something new 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: best practices

Comments

@copumpkin
Copy link
Member

The underlying substituter ignores uppercase variable names (intentionally, per #9482) so we should tell people that if they pass in uppercase variables, things are going to break.

hedning added a commit to hedning/nixpkgs that referenced this issue Nov 17, 2018
`substituteAll` intentionally doesn't work with all caps:
NixOS#28086
hedning added a commit that referenced this issue Nov 19, 2018
`substituteAll` intentionally doesn't work with all caps:
#28086
jtojnar pushed a commit that referenced this issue Nov 19, 2018
`substituteAll` intentionally doesn't work with all caps:
#28086
jtojnar pushed a commit that referenced this issue Nov 20, 2018
`substituteAll` intentionally doesn't work with all caps:
#28086
hedning added a commit that referenced this issue Nov 21, 2018
`substituteAll` intentionally doesn't work with all caps:
#28086
hedning added a commit to hedning/nixpkgs that referenced this issue Nov 22, 2018
`substituteAll` intentionally doesn't work with all caps:
NixOS#28086
hedning added a commit that referenced this issue Nov 22, 2018
`substituteAll` intentionally doesn't work with all caps:
#28086
jtojnar pushed a commit that referenced this issue Nov 30, 2018
`substituteAll` intentionally doesn't work with all caps:
#28086
@jtojnar jtojnar mentioned this issue Jan 17, 2019
6 tasks
@jtojnar jtojnar mentioned this issue Aug 21, 2019
10 tasks
@stale
Copy link

stale bot commented Jun 5, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: enhancement Add something new 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: best practices
Projects
None yet
Development

No branches or pull requests

2 participants