-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jazzy: 0.9.0 -> 0.9.5 #56399
jazzy: 0.9.0 -> 0.9.5 #56399
Conversation
What does it take to get package updates processed? |
Also add myself as a maintainer.
I've updated the commit to add myself as a maintainer of the package as well, as @peterromfeldhk does not seem to be particularly responsive. |
@GrahamcOfBorg build jazzy |
its not like i can merge it :/ why do i need to respond if there is nothing
i can do?
…On Thu, Mar 7, 2019 at 6:06 AM Lily Ballard ***@***.***> wrote:
I've updated the commit to add myself as a maintainer of the package as
well, as @peterromfeldhk <https://github.com/peterromfeldhk> does not
seem to be particularly responsive.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#56399 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFQpu8F9y29tPg_XB4JREg1uzyWtAC5lks5vUDwAgaJpZM4bRfwi>
.
|
@peterromfeldhk As the listed maintainer you should at least approve (or reject) the change. |
@peterromfeldhk You could use https://github.com/Mic92/nix-review |
hmm ok, i looked at it (it was fine). there was no approve button, but i
can add approve comment if that makes it easier.
…On Thu, Mar 14, 2019 at 10:14 AM Ryan Mulligan ***@***.***> wrote:
@peterromfeldhk <https://github.com/peterromfeldhk> You could use
https://github.com/Mic92/nix-review nix-review pr 56399 to build and test
this commit and see if it behaves the way you expect it to.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#56399 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFQpu6Le0ge-b4KLUR36ErrutzadjT9Eks5vWbCegaJpZM4bRfwi>
.
|
Yes, a approval comment from the maintainer is very helpful. Once RFC 39 is implemented it will be possible for you to submit a approval review of PRs in GitHub. |
jazzy: 0.9.0 -> 0.9.5
Motivation for this change
Updates the
jazzy
package.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)/cc @peterromfeldhk
I had to update the
update
script. I did not make it match what we settled on withcocoapods
because askingbundler
to build and install all the packages was actually problematic (not only is it completely unnecessary but I ran into a problem with it depending onsqlite
). So instead we just askbundler
to generate the lockfile and letbundix
do its work and it works just fine. Next timecocoapods
is updated we should probably update itsupdate
script again to match.