llvmPackages.lldb is broken in master

[copumpkin]

Looks like the hash for 3.5 is just a copy of the the hash for 3.4, which means it's a mismatch. Fixing that leads to a big string of variations on

CMake Error at /nix/store/0w3jjmx6zll8kx1fmvwryz2iib9xp0h0-llvm-3.5.0/share/llvm/cmake/AddLLVM.cmake:282 (set_output_directory):
  set_output_directory Function invoked with incorrect arguments for function
  named: set_output_directory
Call Stack (most recent call first):
  CMakeLists.txt:230 (llvm_add_library)
  source/Plugins/Instruction/ARM64/CMakeLists.txt:3 (add_lldb_library)

which I'm not sure how to fix, so I'm leaving this here.

Calling @shlevy 😄

[shlevy]

Crossing my fingers that 3.6 Just Fixes It, @Ralith might be giving the upgrade a shot soon 😄 But I'll take a look at this too.

[copumpkin]

Even if 3.6 does fix it, we probably want to retain support for 3.5 for a while still, right? At some point we should probably kill some of the older LLVM bundles though!

[vcunat]

3.5.1 update doesn't fix it by itself.

[shlevy]

Dug through the cmake code and I have no idea here, sorry.

[Ralith]

lldb 3.6 appears to build fine in #6668, though we won't know for sure until the tests pass.

[shlevy]

@copumpkin Do we need lldb specifically on 3.5? If it's working on 3.6 I'm not sure we need to ensure it is on all versions, you know?

[copumpkin]

Nope, not needed, just a nice-to-have :)

On Mar 5, 2015, at 06:34, Shea Levy notifications@github.com wrote:

@copumpkin Do we need lldb specifically on 3.5? If it's working on 3.6 I'm not sure we need to ensure it is on all versions, you know?

—
Reply to this email directly or view it on GitHub.

[vcunat]

We should at least mark the broken packages as broken. Currently we fail on download, which is misleading.