Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests: add systemd-networkd-ipv6-prefix-delegation #86471

Merged
merged 2 commits into from
May 1, 2020
Merged

nixos/tests: add systemd-networkd-ipv6-prefix-delegation #86471

merged 2 commits into from
May 1, 2020

Conversation

andir
Copy link
Member

@andir andir commented May 1, 2020

Motivation for this change

This is a follow-up to the PR #82026 that contains the promised tests.

In this test I am testing if we can properly propagate prefixes received
via DHCPv6 PD with the networkd options in our module system.

The comments in the test should be sufficient to follow the idea and
what is going on.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andir
Copy link
Member Author

andir commented May 1, 2020

@GrahamcOfBorg test systemd-networkd-ipv6-prefix-delegation

@ofborg ofborg bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label May 1, 2020
@andir
Copy link
Member Author

andir commented May 1, 2020 •
edited
Loading

I would very much like to add this to the tests required for a channel bump. Any objections?

Motivation: I actually have my home router setup like this and it would be a bummer if that breaks ;)

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels May 1, 2020
@andir andir force-pushed the systemd-networkd-prefix-delegation-test branch 3 times, most recently from d54c9f9 to 5337487 Compare May 1, 2020 14:07
@andir andir changed the title nixos/tests/: add systemd-networkd-ipv6-prefix-delegation nixos/tests: add systemd-networkd-ipv6-prefix-delegation May 1, 2020
@mweinelt
Copy link
Member

mweinelt commented May 1, 2020

Looks very well done, loving the documentation bits. Runs perfectly well!

@andir andir force-pushed the systemd-networkd-prefix-delegation-test branch from 5337487 to 28f08ce Compare May 1, 2020 14:12
flokli
flokli reviewed May 1, 2020
View reviewed changes
Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice, thank you :-)

I added some comments.

nixos/tests/systemd-networkd-ipv6-prefix-delegation.nix Outdated Show resolved Hide resolved
nixos/tests/systemd-networkd-ipv6-prefix-delegation.nix Outdated Show resolved Hide resolved
nixos/tests/systemd-networkd-ipv6-prefix-delegation.nix Outdated Show resolved Hide resolved
nixos/tests/systemd-networkd-ipv6-prefix-delegation.nix Show resolved Hide resolved
nixos/tests/systemd-networkd-ipv6-prefix-delegation.nix Outdated Show resolved Hide resolved
nixos/tests/systemd-networkd-ipv6-prefix-delegation.nix Show resolved Hide resolved
nixos/tests/systemd-networkd-ipv6-prefix-delegation.nix Show resolved Hide resolved
nixos/tests/systemd-networkd-ipv6-prefix-delegation.nix Outdated Show resolved Hide resolved
@andir andir force-pushed the systemd-networkd-prefix-delegation-test branch 2 times, most recently from fd4bec2 to 3aeab64 Compare May 1, 2020 14:51
@andir
nixos/tests: add systemd-networkd-ipv6-prefix-delegation
47529bc 
This is a follow-up to the PR NixOS#82026 that contains the promised tests.

In this test I am testing if we can properly propagate prefixes received
via DHCPv6 PD with the networkd options in our module system.

The comments in the test should be sufficient to follow the idea and
what is going on.
@andir andir force-pushed the systemd-networkd-prefix-delegation-test branch from 3aeab64 to 47529bc Compare May 1, 2020 14:56
@flokli
Copy link
Contributor

flokli commented May 1, 2020

👍 on adding this to the tested jobset.

@flokli flokli merged commit 4a2f821 into NixOS:master May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli left review comments

@mweinelt mweinelt mweinelt approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andir @mweinelt @flokli