Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: add CVE identifiers to patches #87139

Merged
merged 1 commit into from
May 6, 2020
Merged

treewide: add CVE identifiers to patches #87139

merged 1 commit into from
May 6, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented May 6, 2020

Motivation for this change

Several patches were missing CVE identiifers which makes tracking their status next to impossible. I've gone through all open vulnerabilites listen on https://broken.sh and added CVE numbers where possible.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andir @flokli

@mweinelt
treewide: add CVE identifiers to patches
e24f5ea 
This allows tools like broken.sh to correctly identify the patched
status.
@andir andir self-assigned this May 6, 2020
@andir
Copy link
Member

andir commented May 6, 2020

nix-review pr … rebuild everything just fine

@andir andir merged commit 38d043b into NixOS:master May 6, 2020
@mweinelt mweinelt deleted the pr/security-patch-names branch May 6, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qknight qknight Awaiting requested review from qknight

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@bennofs bennofs Awaiting requested review from bennofs

@peti peti Awaiting requested review from peti

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees

@andir andir

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mweinelt @andir