-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipython: 3.2 -> 4.0 #9254
ipython: 3.2 -> 4.0 #9254
Conversation
Note that this PR might also have consequences for packages outside |
There are conflicts, can your resolve them please? |
@pSub rebased to master |
@geerds gnome3.accerciser: init at 3.14.0 requires |
Note that tests fail because of apparently a bug in the dependency pytestrunner. The latest version of pathpy is 8.0. However, that version breaks the qtconsole.
Built locally with It would be nice to have this merged as soon as possible before anything breaks it again. |
The qtconsole used to be part of the ipython package.
The Jupyter notebook used to be part of ipython
The build failed due to running out of memory |
sha256 = "e775a40ee4a3a1d45018b199c44cc20bbe7f3df2dc8882f61465bb4141c78cdb"; | ||
}; | ||
|
||
buildInputs = with self; [setuptools_scm pytest]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The nix style seems to be to have a space between [
and content. I.e. [ setuptools_scm pytest ]
(and in all other locations)
I've tested this with nox-review which generated 94 outputs successfully and I've executed a few things (e.g. ipython) and they seem to work fine. IMO this is ready to go. |
This PR features The Big Split
This PR includes all dependencies needed.
ipython
is now a small package. If you want to have the notebook, you need to installpythonXXPackages.notebook
and if you want to have the qtconsole. you need to install
pythonXXPackages.qtconsole
Guess I now need to rebase onto master because of the earlier update to
ipython 3.2.1
cc maintainers @bjornfor @jgeerds