Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipython: 3.2 -> 4.0 #9254

Merged
merged 17 commits into from
Sep 8, 2015
Merged

ipython: 3.2 -> 4.0 #9254

merged 17 commits into from
Sep 8, 2015

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Aug 14, 2015

This PR features The Big Split

IPython 3 was the last major monolithic release of IPython containing all of the language-agnostic code, such as the notebook, which is moving under the new name Jupyter. As part of that process, we have created several discrete packages for each component - nbformat for the notebook format, nbconvert for the notebook conversion machinery, notebook for the HTML notebook application, etc.

This PR includes all dependencies needed.
ipython is now a small package. If you want to have the notebook, you need to install
pythonXXPackages.notebook
and if you want to have the qtconsole. you need to install
pythonXXPackages.qtconsole

Guess I now need to rebase onto master because of the earlier update to ipython 3.2.1

cc maintainers @bjornfor @jgeerds

@FRidh
Copy link
Member Author

FRidh commented Aug 14, 2015

Note that this PR might also have consequences for packages outside python-packages.nix.
For example, there is a haskell kernel, cc @peti

@pSub
Copy link
Member

pSub commented Aug 14, 2015

There are conflicts, can your resolve them please?

@FRidh
Copy link
Member Author

FRidh commented Aug 15, 2015

@pSub rebased to master

@FRidh
Copy link
Member Author

FRidh commented Aug 15, 2015

@geerds gnome3.accerciser: init at 3.14.0 requires ipythonLight which I removed in this PR. Is the new ipython package sufficient? And if so, which version, 2.7 or 3.4?

@FRidh FRidh changed the title ipython: 3.2 -> 4.0 ipython: 3.2 -> 4.0 - WIP Aug 15, 2015
@pSub pSub added the 2.status: work-in-progress This PR isn't done label Aug 15, 2015
@FRidh FRidh changed the title ipython: 3.2 -> 4.0 - WIP ipython: 3.2 -> 4.0 Aug 29, 2015
@FRidh
Copy link
Member Author

FRidh commented Aug 29, 2015

Built locally with nix-shell -I nixpkgs=. -p XXPackages.notebook XXPackages.qtconsole for all Python versions. Ran jupyter notebook and jupyter qtconsole successfully in all cases. I didn't use nox-review wip.

It would be nice to have this merged as soon as possible before anything breaks it again.

@FRidh
Copy link
Member Author

FRidh commented Aug 29, 2015

The build failed due to running out of memory

sha256 = "e775a40ee4a3a1d45018b199c44cc20bbe7f3df2dc8882f61465bb4141c78cdb";
};

buildInputs = with self; [setuptools_scm pytest];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nix style seems to be to have a space between [ and content. I.e. [ setuptools_scm pytest ] (and in all other locations)

@teh
Copy link
Contributor

teh commented Sep 7, 2015

I've tested this with nox-review which generated 94 outputs successfully and I've executed a few things (e.g. ipython) and they seem to work fine. IMO this is ready to go.

pSub added a commit that referenced this pull request Sep 8, 2015
@pSub pSub merged commit c11dc40 into NixOS:master Sep 8, 2015
@FRidh FRidh deleted the jupyter branch September 19, 2015 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: work-in-progress This PR isn't done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants