-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.yappi: 1.2.5 -> 1.3.0 #101054
Conversation
checkInputs = [ nose ]; | ||
checkInputs = [ gevent ]; | ||
checkPhase = '' | ||
${python}/bin/python run_tests.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to support alternate python implementations
${python}/bin/python run_tests.py | |
${python.interpreter} run_tests.py |
Fails for me on macos 10.14
This looks like another timing based test, which are notoriously flakey. Wonder if we could find a sneaky way to disable the timing checks without disabling the surrounding tests. |
I will be trying to reproduce the error. However in the meantime: assert almost equal function accepts a err rate param which can be changed which I feel can be useful in your situation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of nixpkgs-review pr 101054 1
2 packages built:
- python37Packages.yappi
- python38Packages.yappi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of nixpkgs-review pr 101054 1
2 packages built:
- python37Packages.yappi
- python38Packages.yappi
Motivation for this change
ZHF 20.09 #97479
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)