Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

betterdiscord-installer: init at 1.0.0-beta #118471

Merged

Conversation

IvarWithoutBones
Copy link
Member

Motivation for this change

Seems to be working out of the box for me.

cc @ObserverOfTime

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 4, 2021
@ObserverOfTime
Copy link

Wouldn't betterdiscord-installer or simply betterdiscord be a better name?

@TheOPtimal
Copy link

I think a better-suited name would be betterdiscord-installer, since installing the package doesn't automatically just install it in Discord - you have to run the installer.

@IvarWithoutBones
Copy link
Member Author

IvarWithoutBones commented Apr 5, 2021

I think a better-suited name would be betterdiscord-installer, since installing the package doesn't automatically just install it in Discord - you have to run the installer.

I agree, I've changed the package's name to that.

@SuperSandro2000 should be ready to be merged now 👍

@SuperSandro2000 SuperSandro2000 changed the title betterdiscordinstaller: init at 1.0.0-beta betterdiscord-installer: init at 1.0.0-beta Apr 7, 2021
@SuperSandro2000 SuperSandro2000 merged commit 8daf0ce into NixOS:master Apr 7, 2021
cideM pushed a commit to cideM/nixpkgs that referenced this pull request Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants