-
-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vala: drop 0.36, 0.44 #127243
vala: drop 0.36, 0.44 #127243
Conversation
Looks like birdfont has been pinned in #70344. But it was an older version then so perhaps pinning is indeed not necessary these days. It would definitely be better to track latest Vala if it builds with it. |
I've unpinned vala for birdfont then, at least for 0.52 it builds fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want aliases for those?
We don't do that when dropping old golang versions. I don't have any strong opinions either way here. It's probably fine to not do it, but also probably better practice to actually add them for versioned packages. |
Result of 1 package built successfully:
3 suggestions:
|
vala_0_44 already dropped in NixOS#127243
Motivation for this change
Both have been EOL for a while.
This necessitated bumping birdfont to a newer version. It seems to build and run fine with either 0.48 and 0.52, but I just moved it to the closest LTS release. Perhaps we don't need to pin vala versions at all here?
Dropping 0.46 seems a bit more annoying, so I'll try doing that later in a separate PR.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)