Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vala: drop 0.36, 0.44 #127243

Merged
merged 3 commits into from
Jun 24, 2021
Merged

vala: drop 0.36, 0.44 #127243

merged 3 commits into from
Jun 24, 2021

Conversation

amaxine
Copy link
Contributor

@amaxine amaxine commented Jun 17, 2021

Motivation for this change

Both have been EOL for a while.

This necessitated bumping birdfont to a newer version. It seems to build and run fine with either 0.48 and 0.52, but I just moved it to the closest LTS release. Perhaps we don't need to pin vala versions at all here?

Dropping 0.46 seems a bit more annoying, so I'll try doing that later in a separate PR.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from dtzWill June 17, 2021 17:25
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 17, 2021
@amaxine amaxine requested a review from jtojnar June 17, 2021 23:44
@jtojnar
Copy link
Member

jtojnar commented Jun 18, 2021

Looks like birdfont has been pinned in #70344. But it was an older version then so perhaps pinning is indeed not necessary these days. It would definitely be better to track latest Vala if it builds with it.

@amaxine
Copy link
Contributor Author

amaxine commented Jun 18, 2021

I've unpinned vala for birdfont then, at least for 0.52 it builds fine.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want aliases for those?

@amaxine
Copy link
Contributor Author

amaxine commented Jun 18, 2021

We don't do that when dropping old golang versions. I don't have any strong opinions either way here. It's probably fine to not do it, but also probably better practice to actually add them for versioned packages.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 127243 at c352a08 run on x86_64-linux 1

1 package built successfully:
  • birdfont
3 suggestions:
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/tools/misc/birdfont/default.nix:24:3:

       |
    24 |   buildPhase = "./build.py";
       |   ^
    
  • warning: unclear-gpl

    gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

    Near pkgs/tools/misc/birdfont/default.nix:31:5:

       |
    31 |     license = licenses.gpl3;
       |     ^
    
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/tools/misc/birdfont/default.nix:26:3:

       |
    26 |   installPhase = "./install.py";
       |   ^
    

@jtojnar jtojnar merged commit a01a771 into NixOS:master Jun 24, 2021
@amaxine amaxine deleted the vala_cleanup branch July 19, 2021 13:22
bobby285271 added a commit to bobby285271/nixpkgs that referenced this pull request Dec 3, 2021
@bobby285271 bobby285271 mentioned this pull request Dec 3, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants