Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coreboot-toolchain: Init at 4.14 #128592

Merged
merged 1 commit into from
Sep 30, 2021
Merged

coreboot-toolchain: Init at 4.14 #128592

merged 1 commit into from
Sep 30, 2021

Conversation

felixsinger
Copy link
Member

@felixsinger felixsinger commented Jun 29, 2021 •
edited
Loading

Motivation for this change

Packaging the coreboot toolchain.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 29, 2021
@felixsinger felixsinger force-pushed the pkgs/add-coreboot-toolchain branch 2 times, most recently from be953df to 74c5eea Compare June 30, 2021 21:01
orangecms
orangecms approved these changes Jul 1, 2021
View reviewed changes
Copy link

@orangecms orangecms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! \o/

This was referenced Jul 8, 2021
Closed
Open
@felixsinger felixsinger marked this pull request as ready for review September 13, 2021 23:16
@felixsinger felixsinger requested review from yu-re-ka and a user September 13, 2021 23:16
@felixsinger
coreboot-toolchain: Init at 4.14
f0b20ba 
Signed-off-by: Felix Singer <felixsinger@posteo.net>
@felixsinger
Copy link
Member Author

Anything left to do?

@Lassulus
Copy link
Member

Result of nixpkgs-review pr 128592 run on x86_64-linux 1

1 package built:
  • coreboot-toolchain

@Lassulus Lassulus merged commit 94c6545 into NixOS:master Sep 30, 2021
@felixsinger felixsinger deleted the pkgs/add-coreboot-toolchain branch September 30, 2021 16:21
samueldr
samueldr reviewed Oct 7, 2021
View reviewed changes
pkgs/development/tools/misc/coreboot-toolchain/default.nix
description = "coreboot toolchain";
license = with licenses; [ bsd2 bsd3 gpl2 lgpl2Plus gpl3Plus ];
maintainers = with maintainers; [ felixsinger ];
platforms = platforms.linux;
Copy link
Member

@samueldr samueldr Oct 7, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fetching prebuilt binaries for x86_64. Thus, this works on only one of the fourteen Linux platforms.

platforms = ["x86_64-linux"];

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh? Where is it fetching prebuilt binaries?

Copy link
Member

@samueldr samueldr Oct 7, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wrong in my analysis. I guess the aarch64 community box already had a build cached. I assumed from the time it took building (not much).

But now I'm extremely confused. The aarch64 community box is not accessible, so I can't check what I did (and it's likely it would have been wiped). Now I get an unceremonious "Platform not supported" on aarch64.

So I guess ignore my comment? I don't know how I got x86_64 binaries on the community box yesterday. (Maybe I did a mistake and wasn't ssh'd as I thought, even?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr samueldr left review comments

@orangecms orangecms orangecms approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@yu-re-ka yu-re-ka Awaiting requested review from yu-re-ka

@mweinelt mweinelt Awaiting requested review from mweinelt

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@piegamesde piegamesde Awaiting requested review from piegamesde

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@felixsinger @Lassulus @samueldr @orangecms @SuperSandro2000 @yu-re-ka