dtc: disable checks for darwin

[tnias]

Motivation for this change

The tests fail on darwin aarch64.

#118700 (comment)

Reported-by: Jiuyang Liu (@sequencer)

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• 21.11 Release Notes (or backporting 21.05 Relase notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[tnias]

Hey @sequencer 👋

Due to missing hadware I can't verify the issues on aarch64-darwin. Can you please check if this properly builds and if the resulting tools are working as expected on aarch64 darwin?

[SuperSandro2000]

Please add a comment why you disabled tests.

[tnias]

done

[sequencer]

Due to missing hadware I can't verify the issues on aarch64-darwin. Can you please check if this properly builds and if the resulting tools are working as expected on aarch64 darwin?

test with command below:

❯ nix-shell --pure -p dtc
this derivation will be built:
  /nix/store/f7kzky2ly9jqlkcwcci0liffrgvwwsac-dtc-1.6.0.drv
building '/nix/store/f7kzky2ly9jqlkcwcci0liffrgvwwsac-dtc-1.6.0.drv'...
unpacking sources
unpacking source archive /nix/store/agdd1n201rkrmpg4ixkvb73pfskg96kz-dtc
source root is dtc
patching sources
patching script interpreter paths in pylibfdt/
updateAutotoolsGnuConfigScriptsPhase
configuring
no configure script, doing nothing
building
build flags: SHELL=/nix/store/y0jf239rcgd8g2y1mf0jmgrlxki40id0-bash-4.4-p23/bin/bash PYTHON=python
         DEP tests/dumptrees.c
         DEP tests/trees.S
         DEP tests/testutils.c
         DEP tests/value-labels.c
         DEP tests/asm_tree_dump.c
         DEP tests/truncated_memrsv.c
         DEP tests/truncated_string.c
         DEP tests/truncated_property.c
         DEP tests/fs_tree1.c
         DEP tests/check_full.c
         DEP tests/check_header.c
         DEP tests/check_path.c
         DEP tests/overlay_bad_fixup.c
         DEP tests/overlay.c
         DEP tests/subnode_iterate.c
         DEP tests/property_iterate.c
         DEP tests/integer-expressions.c
         DEP tests/utilfdt_test.c
         DEP tests/path_offset_aliases.c
         DEP tests/add_subnode_with_nops.c
         DEP tests/dtbs_equal_unordered.c
         DEP tests/dtb_reverse.c
         DEP tests/dtbs_equal_ordered.c
         DEP tests/extra-terminating-null.c
         DEP tests/incbin.c
         DEP tests/boot-cpuid.c
         DEP tests/phandle_format.c
         DEP tests/path-references.c
         DEP tests/references.c
         DEP tests/string_escapes.c
         DEP tests/propname_escapes.c
         DEP tests/appendprop2.c
         DEP tests/appendprop1.c
         DEP tests/del_node.c
         DEP tests/del_property.c
         DEP tests/setprop.c
         DEP tests/set_name.c
         DEP tests/rw_oom.c
         DEP tests/rw_tree1.c
         DEP tests/open_pack.c
         DEP tests/nopulate.c
         DEP tests/mangle-layout.c
         DEP tests/move_and_save.c
         DEP tests/sw_states.c
         DEP tests/sw_tree1.c
         DEP tests/nop_node.c
         DEP tests/nop_property.c
         DEP tests/setprop_inplace.c
         DEP tests/stringlist.c
         DEP tests/appendprop_addrrange.c
         DEP tests/addr_size_cells2.c
         DEP tests/addr_size_cells.c
         DEP tests/notfound.c
         DEP tests/sized_cells.c
         DEP tests/char_literal.c
         DEP tests/get_alias.c
         DEP tests/node_offset_by_compatible.c
         DEP tests/node_check_compatible.c
         DEP tests/node_offset_by_phandle.c
         DEP tests/node_offset_by_prop_value.c
         DEP tests/parent_offset.c
         DEP tests/supernode_atdepth_offset.c
         DEP tests/get_path.c
         DEP tests/get_phandle.c
         DEP tests/get_prop_offset.c
         DEP tests/getprop.c
         DEP tests/get_name.c
         DEP tests/path_offset.c
         DEP tests/subnode_offset.c
         DEP tests/find_property.c
         DEP tests/root_node.c
         DEP tests/get_mem_rsv.c
         DEP libfdt/fdt_check.c
         DEP libfdt/fdt_overlay.c
         DEP libfdt/fdt_addresses.c
         DEP libfdt/fdt_empty_tree.c
         DEP libfdt/fdt_strerror.c
         DEP libfdt/fdt_rw.c
         DEP libfdt/fdt_sw.c
         DEP libfdt/fdt_wip.c
         DEP libfdt/fdt_ro.c
         DEP libfdt/fdt.c
         DEP util.c
         DEP fdtoverlay.c
         DEP fdtput.c
         DEP fdtget.c
         DEP fdtdump.c
         LEX convert-dtsv0-lexer.lex.c
         DEP convert-dtsv0-lexer.lex.c
         DEP srcpos.c
         BISON dtc-parser.tab.c
         DEP dtc-parser.tab.c
         LEX dtc-lexer.lex.c
         DEP dtc-lexer.lex.c
         DEP yamltree.c
         DEP treesource.c
         DEP livetree.c
         DEP fstree.c
         DEP flattree.c
         DEP dtc.c
         DEP data.c
         DEP checks.c
        CHK version_gen.h
        UPD version_gen.h
         DEP util.c
        CHK version_gen.h
         CC srcpos.o
         CC util.o
         CC convert-dtsv0-lexer.lex.o
         LD convert-dtsv0
         CC dtc.o
         CC checks.o
         CC data.o
         CC flattree.o
         CC fstree.o
         CC livetree.o
         CC treesource.o
         CC yamltree.o
         CC dtc-lexer.lex.o
         CC dtc-parser.tab.o
         LD dtc
         CC fdtdump.o
         LD fdtdump
         CC fdtget.o
         CC libfdt/fdt.o
         CC libfdt/fdt_ro.o
         CC libfdt/fdt_wip.o
         CC libfdt/fdt_sw.o
         CC libfdt/fdt_rw.o
         CC libfdt/fdt_strerror.o
         CC libfdt/fdt_empty_tree.o
         CC libfdt/fdt_addresses.o
         CC libfdt/fdt_overlay.o
         CC libfdt/fdt_check.o
         LD libfdt/libfdt-1.6.0.dylib
         LD fdtget
         CC fdtput.o
         LD fdtput
         CC fdtoverlay.o
         LD fdtoverlay
         AR libfdt/libfdt.a
## Skipping pylibfdt (install python dev and swig to build)
running tests
check flags: SHELL=/nix/store/y0jf239rcgd8g2y1mf0jmgrlxki40id0-bash-4.4-p23/bin/bash PYTHON=python VERBOSE=y check
        CHK version_gen.h
         CC tests/get_mem_rsv.o
         CC tests/testutils.o
         LD tests/get_mem_rsv
         CC tests/root_node.o
         LD tests/root_node
         CC tests/find_property.o
         LD tests/find_property
         CC tests/subnode_offset.o
         LD tests/subnode_offset
         CC tests/path_offset.o
         LD tests/path_offset
         CC tests/get_name.o
         LD tests/get_name
         CC tests/getprop.o
         LD tests/getprop
         CC tests/get_prop_offset.o
         LD tests/get_prop_offset
         CC tests/get_phandle.o
         LD tests/get_phandle
         CC tests/get_path.o
         LD tests/get_path
         CC tests/supernode_atdepth_offset.o
         LD tests/supernode_atdepth_offset
         CC tests/parent_offset.o
         LD tests/parent_offset
         CC tests/node_offset_by_prop_value.o
         LD tests/node_offset_by_prop_value
         CC tests/node_offset_by_phandle.o
         LD tests/node_offset_by_phandle
         CC tests/node_check_compatible.o
         LD tests/node_check_compatible
         CC tests/node_offset_by_compatible.o
         LD tests/node_offset_by_compatible
         CC tests/get_alias.o
         LD tests/get_alias
         CC tests/char_literal.o
         LD tests/char_literal
         CC tests/sized_cells.o
         LD tests/sized_cells
         CC tests/notfound.o
         LD tests/notfound
         CC tests/addr_size_cells.o
         LD tests/addr_size_cells
         CC tests/addr_size_cells2.o
         LD tests/addr_size_cells2
         CC tests/appendprop_addrrange.o
         LD tests/appendprop_addrrange
         CC tests/stringlist.o
         LD tests/stringlist
         CC tests/setprop_inplace.o
         LD tests/setprop_inplace
         CC tests/nop_property.o
         LD tests/nop_property
         CC tests/nop_node.o
         LD tests/nop_node
         CC tests/sw_tree1.o
         LD tests/sw_tree1
         CC tests/sw_states.o
         LD tests/sw_states
         CC tests/move_and_save.o
         LD tests/move_and_save
         CC tests/mangle-layout.o
         LD tests/mangle-layout
         CC tests/nopulate.o
         LD tests/nopulate
         CC tests/open_pack.o
         LD tests/open_pack
         CC tests/rw_tree1.o
         LD tests/rw_tree1
         CC tests/rw_oom.o
         LD tests/rw_oom
         CC tests/set_name.o
         LD tests/set_name
         CC tests/setprop.o
         LD tests/setprop
         CC tests/del_property.o
         LD tests/del_property
         CC tests/del_node.o
         LD tests/del_node
         CC tests/appendprop1.o
         LD tests/appendprop1
         CC tests/appendprop2.o
         LD tests/appendprop2
         CC tests/propname_escapes.o
         LD tests/propname_escapes
         CC tests/string_escapes.o
         LD tests/string_escapes
         CC tests/references.o
         LD tests/references
         CC tests/path-references.o
         LD tests/path-references
         CC tests/phandle_format.o
         LD tests/phandle_format
         CC tests/boot-cpuid.o
         LD tests/boot-cpuid
         CC tests/incbin.o
         LD tests/incbin
         CC tests/extra-terminating-null.o
         LD tests/extra-terminating-null
         CC tests/dtbs_equal_ordered.o
         LD tests/dtbs_equal_ordered
         CC tests/dtb_reverse.o
         LD tests/dtb_reverse
         CC tests/dtbs_equal_unordered.o
         LD tests/dtbs_equal_unordered
         CC tests/add_subnode_with_nops.o
         LD tests/add_subnode_with_nops
         CC tests/path_offset_aliases.o
         LD tests/path_offset_aliases
         CC tests/utilfdt_test.o
         LD tests/utilfdt_test
         CC tests/integer-expressions.o
         LD tests/integer-expressions
         CC tests/property_iterate.o
         LD tests/property_iterate
         CC tests/subnode_iterate.o
         LD tests/subnode_iterate
         CC tests/overlay.o
         LD tests/overlay
         CC tests/overlay_bad_fixup.o
         LD tests/overlay_bad_fixup
         CC tests/check_path.o
         LD tests/check_path
         CC tests/check_header.o
         LD tests/check_header
         CC tests/check_full.o
         LD tests/check_full
         CC tests/fs_tree1.o
         LD tests/fs_tree1
         CC tests/truncated_property.o
         AS tests/trees.o
tests/trees.S:216:8: error: expected relocatable expression
 .byte ((ovf_size_strings_end - ovf_size_strings) >> 24) & 0xff ; .byte ((ovf_size_strings_end - ovf_size_strings) >> 16) & 0xff ; .byte ((ovf_size_strings_end - ovf_size_strings) >> 8) & 0xff ; .byte (ovf_size_strings_end - ovf_size_strings) & 0xff ;
       ^
tests/trees.S:217:8: error: expected relocatable expression
 .byte ((ovf_size_strings_struct - ovf_size_strings) >> 24) & 0xff ; .byte ((ovf_size_strings_struct - ovf_size_strings) >> 16) & 0xff ; .byte ((ovf_size_strings_struct - ovf_size_strings) >> 8) & 0xff ; .byte (ovf_size_strings_struct - ovf_size_strings) & 0xff ;
       ^
tests/trees.S:218:8: error: expected relocatable expression
 .byte ((ovf_size_strings_strings - ovf_size_strings) >> 24) & 0xff ; .byte ((ovf_size_strings_strings - ovf_size_strings) >> 16) & 0xff ; .byte ((ovf_size_strings_strings - ovf_size_strings) >> 8) & 0xff ; .byte (ovf_size_strings_strings - ovf_size_strings) & 0xff ;
       ^
tests/trees.S:219:8: error: expected relocatable expression
 .byte ((ovf_size_strings_rsvmap - ovf_size_strings) >> 24) & 0xff ; .byte ((ovf_size_strings_rsvmap - ovf_size_strings) >> 16) & 0xff ; .byte ((ovf_size_strings_rsvmap - ovf_size_strings) >> 8) & 0xff ; .byte (ovf_size_strings_rsvmap - ovf_size_strings) & 0xff ;
       ^
tests/trees.S:224:8: error: expected relocatable expression
 .byte ((ovf_size_strings_struct_end - ovf_size_strings_struct) >> 24) & 0xff ; .byte ((ovf_size_strings_struct_end - ovf_size_strings_struct) >> 16) & 0xff ; .byte ((ovf_size_strings_struct_end - ovf_size_strings_struct) >> 8) & 0xff ; .byte (ovf_size_strings_struct_end - ovf_size_strings_struct) & 0xff ;
       ^
make: *** [Makefile:349: tests/trees.o] Error 1
error: builder for '/nix/store/f7kzky2ly9jqlkcwcci0liffrgvwwsac-dtc-1.6.0.drv' failed with exit code 2