-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rgbds: 0.4.2 -> 0.5.1 #132928
rgbds: 0.4.2 -> 0.5.1 #132928
Conversation
This also changes the owner of the GitHub repository and the homepage URL because the repository was moved to a different organisation (the old GitHub repository now redirects to the new one). Also, since upstream switched to GNU Bison[1], the comment about byacc is no longer necessary. [1] gbdev/rgbds#595
Diff LGTM; smoke-tested the new release and didn't encounter issues. |
Fails to build on macos 10.15:
|
darwin failure is preexisting https://github.com/nix-community/hydra-check |
Can I reproduce this failure interactively if I don't own a Mac? |
I was going by https://hydra.nixos.org/build/148999310 |
And now sure enough https://hydra.nixos.org/build/149744255 |
Upstream suggests using up-to-date clang for the Mac build, as that's what gets tested. Not sure how I can check whether that fixes the build, as, again, I don't have a Mac to test with. |
This also changes the owner of the GitHub repository and the homepage
URL because the repository was moved to a different organisation (the
old GitHub repository now redirects to the new one).
Also, since upstream switched to GNU Bison[1], the comment about byacc
is no longer necessary.
[1] gbdev/rgbds#595
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)