Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgbds: 0.4.2 -> 0.5.1 #132928

Merged
merged 1 commit into from
Aug 7, 2021
Merged

rgbds: 0.4.2 -> 0.5.1 #132928

merged 1 commit into from
Aug 7, 2021

Conversation

sbruder
Copy link
Contributor

@sbruder sbruder commented Aug 6, 2021

This also changes the owner of the GitHub repository and the homepage
URL because the repository was moved to a different organisation (the
old GitHub repository now redirects to the new one).

Also, since upstream switched to GNU Bison[1], the comment about byacc
is no longer necessary.

[1] gbdev/rgbds#595

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

This also changes the owner of the GitHub repository and the homepage
URL because the repository was moved to a different organisation (the
old GitHub repository now redirects to the new one).

Also, since upstream switched to GNU Bison[1], the comment about byacc
is no longer necessary.

[1] gbdev/rgbds#595
@r-rmcgibbo
Copy link

r-rmcgibbo commented Aug 6, 2021

Result of nixpkgs-review pr 132928 at bf6d934 run on x86_64-linux 1

2 packages built successfully:
  • rgbds
  • sameboy

Result of nixpkgs-review pr 132928 at bf6d934 run on aarch64-linux 1

2 packages built successfully:
  • rgbds
  • sameboy

@meithecatte
Copy link
Contributor

Diff LGTM; smoke-tested the new release and didn't encounter issues.

@risicle
Copy link
Contributor

risicle commented Aug 7, 2021

Fails to build on macos 10.15:

builder for '/nix/store/lb40f7qys8d0909ig60rzpq71pmnf3b4-rgbds-0.5.1.drv' failed with exit code 2; last 10 log lines:
  ld: warning: ignoring file src/hashmap.o, building for macOS-x86_64 but attempting to link with file built for unknown-unsupported file format ( 0xDE 0xC0 0x17 0x0B 0x00 0x00 0x00 0x00 0x14 0x00 0x00 0x00 0x90 0x1B 0x00 0x00 )
  ld: warning: ignoring file src/linkdefs.o, building for macOS-x86_64 but attempting to link with file built for unknown-unsupported file format ( 0xDE 0xC0 0x17 0x0B 0x00 0x00 0x00 0x00 0x14 0x00 0x00 0x00 0x64 0x09 0x00 0x00 )
  ld: warning: ignoring file src/opmath.o, building for macOS-x86_64 but attempting to link with file built for unknown-unsupported file format ( 0xDE 0xC0 0x17 0x0B 0x00 0x00 0x00 0x00 0x14 0x00 0x00 0x00 0x68 0x0D 0x00 0x00 )
  ld: warning: ignoring file /private/tmp/nix-build-rgbds-0.5.1.drv-0/version-0dd1e3.o, building for macOS-x86_64 but attempting to link with file built for unknown-unsupported file format ( 0xDE 0xC0 0x17 0x0B 0x00 0x00 0x00 0x00 0x14 0x00 0x00 0x00 0x64 0x08 0x00 0x00 )
  Undefined symbols for architecture x86_64:
    "_main", referenced from:
       implicit entry/start for main executable
  ld: symbol(s) not found for architecture x86_64
  clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
  make: *** [Makefile:109: rgbasm] Error 1

@Artturin
Copy link
Member

Artturin commented Aug 7, 2021

darwin failure is preexisting https://github.com/nix-community/hydra-check

@meithecatte
Copy link
Contributor

Can I reproduce this failure interactively if I don't own a Mac?

@SuperSandro2000 SuperSandro2000 merged commit d7e3a72 into NixOS:master Aug 7, 2021
@risicle
Copy link
Contributor

risicle commented Aug 7, 2021

I was going by https://hydra.nixos.org/build/148999310

@risicle
Copy link
Contributor

risicle commented Aug 9, 2021

And now sure enough https://hydra.nixos.org/build/149744255

@meithecatte
Copy link
Contributor

Upstream suggests using up-to-date clang for the Mac build, as that's what gets tested. Not sure how I can check whether that fixes the build, as, again, I don't have a Mac to test with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants