-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Telegram Desktop #14266
Add Telegram Desktop #14266
Conversation
By analyzing the blame information on this pull request, we identified @edolstra, @copumpkin and @peti to be potential reviewers |
''; | ||
|
||
meta = with stdenv.lib; { | ||
description = "Utility library providing GObject-based interfaces and classes for commonly used data structures"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope this line is a typo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy-paste error. Thanks, fixed!
I hope |
Yes, I've taken extra care to ensure plain |
Official Telegram client doesn't support alternative input methods (like uim). It seems like this is due to the fact they use their own version of Qt. Do you have any idea how to fix this? |
We can try to patch it to use proper system Qt, but that can quickly turn tricky. See telegramdesktop/tdesktop#1815 |
cc @volhovm |
Waow. Because a chat app is so complicated, of course they couldn't use the regular Qt API. |
Things done:
nix-build --option build-use-chroot true
or nix.useChroot on NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)More
Adds Telegram Desktop and required packages.
P.S.: In my personal rating of packages with completely crazy, "because f*ck you that's why" build sequences this would make a top, and for a long time I feel. The most funny thing is that, modulo several improvements for using more system libraries and more
INCLUDEPATH
s than expected (Because why use pkg-config? Let's just hardcode FHS paths for all packages we use and their dependencies by hand!), this is an official building procedure (see 1). Yes, with a statically built Qt with custom patches "because our font rendering engine uses internal Qt calls". Yes, with sed-patches and manual adding ofLIBS
to link to. Yes, with thisgrep ... | sed ... | xargs make
-- because why spend time to figure out how to properly list dependencies in QMake? And even -- yes, with Arch AUR package as an official source for .desktop files.Not a nice package, certainly. If you spot any profanity in the code, please excuse me -- I was forced.