Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Telegram Desktop #14266

Merged
merged 6 commits into from
Mar 30, 2016
Merged

Add Telegram Desktop #14266

merged 6 commits into from
Mar 30, 2016

Conversation

abbradar
Copy link
Member

Things done:
  • Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.
More

Adds Telegram Desktop and required packages.

P.S.: In my personal rating of packages with completely crazy, "because f*ck you that's why" build sequences this would make a top, and for a long time I feel. The most funny thing is that, modulo several improvements for using more system libraries and more INCLUDEPATHs than expected (Because why use pkg-config? Let's just hardcode FHS paths for all packages we use and their dependencies by hand!), this is an official building procedure (see 1). Yes, with a statically built Qt with custom patches "because our font rendering engine uses internal Qt calls". Yes, with sed-patches and manual adding of LIBS to link to. Yes, with this grep ... | sed ... | xargs make -- because why spend time to figure out how to properly list dependencies in QMake? And even -- yes, with Arch AUR package as an official source for .desktop files.

Not a nice package, certainly. If you spot any profanity in the code, please excuse me -- I was forced.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @edolstra, @copumpkin and @peti to be potential reviewers

'';

meta = with stdenv.lib; {
description = "Utility library providing GObject-based interfaces and classes for commonly used data structures";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this line is a typo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy-paste error. Thanks, fixed!

@7c6f434c
Copy link
Member

I hope pcre path didn't change in the pcre8 variant? Looks good to me.

@abbradar
Copy link
Member Author

Yes, I've taken extra care to ensure plain pcre is not affected. Travis error is due to log growing too much. I'll merge this in several days to leave a window for review.

@astsmtl
Copy link
Contributor

astsmtl commented Mar 28, 2016

Official Telegram client doesn't support alternative input methods (like uim). It seems like this is due to the fact they use their own version of Qt. Do you have any idea how to fix this?

@abbradar
Copy link
Member Author

We can try to patch it to use proper system Qt, but that can quickly turn tricky. See telegramdesktop/tdesktop#1815

@jagajaga
Copy link
Member

cc @volhovm

@jgillich
Copy link
Member

our font rendering engine uses internal Qt calls

Waow. Because a chat app is so complicated, of course they couldn't use the regular Qt API.

@abbradar abbradar mentioned this pull request Oct 15, 2017
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants