Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbus-python: fix configure dependency on python3 #148193

Merged
merged 1 commit into from
Dec 5, 2021

Conversation

dadada
Copy link
Contributor

@dadada dadada commented Dec 1, 2021

Motivation for this change

Fixes #148195

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@dadada dadada force-pushed the fix-python27-dbus-python branch 2 times, most recently from 392f821 to b20da5f Compare December 1, 2021 21:28
@dadada dadada changed the title dbus-python: add python3 as build dependency dbus-python: fix configure dependency on python3 Dec 1, 2021
@Artturin
Copy link
Member

Artturin commented Dec 1, 2021

needs to target staging

# finding the common merge base will avoid pinging all CODEOWNERs
common=$(git merge-base origin/master origin/staging)
git rebase --onto=$common HEAD~1 # or however many commits you want to pull
git push --force

then change the base branch in the github PR from master -> staging

@jtojnar
Copy link
Member

jtojnar commented Dec 1, 2021

Thanks, though note that Python 2 support will be removed in the next version.

@paperdigits
Copy link
Contributor

Can this be backported to 21.11 as well, please?

@dadada
Copy link
Contributor Author

dadada commented Dec 3, 2021

Thanks, though note that Python 2 support will be removed in the next version.

Will 21.11 be updated with the next (minor) release of dbus-python? If yes, I'd be in favor of not patching this here.

@dadada dadada changed the base branch from master to staging December 3, 2021 21:27
@jtojnar
Copy link
Member

jtojnar commented Dec 3, 2021

I do not think 21.11 will upgrade, it would clearly be a breaking change (especially when we backport this).

@jtojnar
Copy link
Member

jtojnar commented Dec 3, 2021

@GrahamcOfBorg eval

@jtojnar jtojnar merged commit 6f396b0 into NixOS:staging Dec 5, 2021
This was referenced Dec 5, 2021
jtojnar added a commit that referenced this pull request Dec 5, 2021
It breaks at runtime since it still depends on PyGTK.

#148193 is the proper fix.
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2021

Successfully created backport PR #148660 for staging-21.11.

github-actions bot pushed a commit that referenced this pull request Dec 5, 2021
It breaks at runtime since it still depends on PyGTK.

#148193 is the proper fix.
(cherry picked from commit 3410324)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dbus-python build missing python3 during build
5 participants