-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dbus-python: fix configure dependency on python3 #148193
Conversation
bfaee51
to
3db1ab6
Compare
392f821
to
b20da5f
Compare
needs to target staging
then change the base branch in the github PR from |
Thanks, though note that Python 2 support will be removed in the next version. |
Can this be backported to 21.11 as well, please? |
Will 21.11 be updated with the next (minor) release of dbus-python? If yes, I'd be in favor of not patching this here. |
b20da5f
to
02b507e
Compare
I do not think 21.11 will upgrade, it would clearly be a breaking change (especially when we backport this). |
@GrahamcOfBorg eval |
It breaks at runtime since it still depends on PyGTK. #148193 is the proper fix.
Successfully created backport PR #148660 for |
Motivation for this change
Fixes #148195
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes