Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

youtube-dl: 2016.05.21.2 -> 2016.06.19.1 #16338

Merged
merged 1 commit into from Jun 21, 2016
Merged

youtube-dl: 2016.05.21.2 -> 2016.06.19.1 #16338

merged 1 commit into from Jun 21, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jun 19, 2016

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @peti, @AndersonTorres and @FRidh to be potential reviewers

@zimbatm
Copy link
Member

zimbatm commented Jun 19, 2016

Hi, can you please fix the commit to follow the CONTRIBUTING.md pattern?

@fpletz fpletz merged commit 22a7f3a into NixOS:master Jun 21, 2016
@ghost
Copy link
Author

ghost commented Jun 26, 2016

Hi, can you please fix the commit to follow the CONTRIBUTING.md pattern?

Sorry, I missed that. I'll be more careful next time.

bjornfor pushed a commit to bjornfor/nixpkgs that referenced this pull request Jul 16, 2016
adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants