Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix-output-monitor: Add zsh completion for nom-build #163441

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

maralorn
Copy link
Member

@maralorn maralorn commented Mar 9, 2022

Description of changes

I‘d be grateful if someone found similar solutions for bash and fish. Still, this is better than nothing.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

builtins.toFile "completion.zsh" ''
#compdef nom-build
compdef nom-build=nix-build
''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if that file should actually live inside the nix-output-monitor repository instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered about that as well, but currently nom-build itself does not live in that repo. And handing out completion files for an executable that we don‘t offer sounds weird.
I have thought about moving nom-build into the package, but the wrapper to put expect in the patch would be as large as the nom-build script is now.

@mweinelt mweinelt merged commit f262cec into NixOS:master Mar 9, 2022
@maralorn maralorn deleted the nom-zsh-completion branch March 9, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants