Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mongodb-6_0: init at 6.0.1 #190548

Merged
merged 4 commits into from
Oct 11, 2022
Merged

mongodb-6_0: init at 6.0.1 #190548

merged 4 commits into from
Oct 11, 2022

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Sep 9, 2022

Description of changes

This packages MongoDB 6.0.
See individual commits.

CC maintainers: @bluescreen303 @offlinehacker @cstrahan

GitHub: closes #190297

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@kfiz
Copy link

kfiz commented Sep 10, 2022

I'm pretty sure that this will not work for darwin due to SDK incompatibilities. The currently used default SDK is quite old and I already stumbled across incompatible SDKs at mongoldb v5. So I would suggest tagging this accordingly.

@pacien
Copy link
Contributor Author

pacien commented Sep 10, 2022 via email

Copy link
Member

@bryanasdev000 bryanasdev000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, thanks a lot @pacien.

Will try to build on my desktop.

I think we should merge this, so PR #172009 goes to fix old builds and deprecate things.

@@ -121,7 +174,10 @@ in stdenv.mkDerivation rec {
runHook postInstallCheck
'';

installTargets = if (versionAtLeast version "4.4") then "install-core" else "install";
installTargets =
if (versionAtLeast version "6.0") then "install-devcore"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, may be interesting if we standardize around a single installation target in the future.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't they changed default name during version it seems. We can have a slimmer mongo v5 with different target but don't know if people were relying on it so didn't changed the name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mongo executable used in the tests (and useful on its own) moved to
install-devcore in 6.0.

Those are moving targets :)

The `mongo` shell has been deprecated.
The official replacement is `mongosh` from pkgs.mongosh.
@pacien
Copy link
Contributor Author

pacien commented Sep 12, 2022

Rebased to solve confilcts.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/608

@pacien
Copy link
Contributor Author

pacien commented Oct 3, 2022 via email

@bryanasdev000
Copy link
Member

For me it's good to go.

I think all remarks have been taken into account. Is there anything left to do here? (This PR seems to be a requirement for further work on #172009).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

packaging request: MongoDB 6.0
8 participants