Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet-sdk: 6.0.400 -> 6.0.401 #191962

Merged
merged 3 commits into from
Sep 26, 2022
Merged

Conversation

mdarocha
Copy link
Contributor

@mdarocha mdarocha commented Sep 19, 2022

Description of changes

See release notes

Also, in this PR I added an updateScript to dotnet-sdk, which should (coupled with the previous change to exclude package-specific lockfiles, which avoids having to regenerate all lockfiles) allow all dotnet versions to be updated automatically.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left you some comments.

pkgs/development/compilers/dotnet/build-dotnet.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/dotnet/build-dotnet.nix Outdated Show resolved Hide resolved
This update script calls the existing update.sh script with the proper
arguments. If not an SDK package, run a dummy script which allows the update.nix
script to work properly.
This should allow dotnet to be update automatically.
If updating to the latest version, and the local expression already is
the latest version, exit without regenerating everything.
Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you.

Result of nixpkgs-review pr 191962 run on x86_64-linux 1

25 packages built:
  • ArchiSteamFarm
  • boogie (dotnetPackages.Boogie)
  • btcpayserver
  • depotdownloader
  • discordchatexporter-cli
  • dotnet-aspnetcore (dotnet-aspnetcore_6 ,dotnetCorePackages.aspnetcore_6_0)
  • dotnet-runtime (dotnet-runtime_6 ,dotnetCorePackages.runtime_6_0)
  • dotnet-sdk (dotnet-sdk_6 ,dotnetCorePackages.sdk_6_0)
  • formula
  • github-runner
  • jackett
  • jetbrains.rider
  • nbxplorer
  • netcoredbg
  • omnisharp-roslyn
  • opentabletdriver
  • osu-lazer
  • pinta
  • pre-commit
  • prowlarr
  • ps3-disc-dumper
  • radarr
  • ryujinx
  • scarab
  • xivlauncher

@IvarWithoutBones IvarWithoutBones merged commit a53100d into NixOS:master Sep 26, 2022
@mdarocha mdarocha deleted the dotnet-6-update branch September 26, 2022 13:18
@@ -121,6 +122,24 @@ stdenv.mkDerivation (finalAttrs: rec {
"aarch64-darwin" = "osx-arm64";
};

updateScript =
if type != "sdk" then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not add the update script only for type == "sdk" then? This currently prints the warning whenever I try to update GNOME with

nix-shell maintainers/scripts/update.nix --arg predicate '(path: pkg: pkg.updateScript.name or null == "gnome-update-script")'

mdarocha added a commit to mdarocha/nixpkgs that referenced this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants