dotnet-sdk: 6.0.400 -> 6.0.401 #191962
Merged
dotnet-sdk: 6.0.400 -> 6.0.401 #191962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdarocha
force-pushed
the
dotnet-6-update
branch
from
098cb97
to
5588200
Compare
mdarocha
force-pushed
the
dotnet-6-update
branch
from
5588200
to
b658b15
Compare
This update script calls the existing update.sh script with the proper arguments. If not an SDK package, run a dummy script which allows the update.nix script to work properly. This should allow dotnet to be update automatically.
If updating to the latest version, and the local expression already is the latest version, exit without regenerating everything.
mdarocha
force-pushed
the
dotnet-6-update
branch
from
b658b15
to
a9fc578
Compare
IvarWithoutBones
approved these changes
Sep 26, 2022
There was a problem hiding this comment.
Looks good to me, thank you.
Result of nixpkgs-review pr 191962 run on x86_64-linux 1
25 packages built:
- ArchiSteamFarm
- boogie (dotnetPackages.Boogie)
- btcpayserver
- depotdownloader
- discordchatexporter-cli
- dotnet-aspnetcore (dotnet-aspnetcore_6 ,dotnetCorePackages.aspnetcore_6_0)
- dotnet-runtime (dotnet-runtime_6 ,dotnetCorePackages.runtime_6_0)
- dotnet-sdk (dotnet-sdk_6 ,dotnetCorePackages.sdk_6_0)
- formula
- github-runner
- jackett
- jetbrains.rider
- nbxplorer
- netcoredbg
- omnisharp-roslyn
- opentabletdriver
- osu-lazer
- pinta
- pre-commit
- prowlarr
- ps3-disc-dumper
- radarr
- ryujinx
- scarab
- xivlauncher
jtojnar
reviewed
Oct 11, 2022
| @@ -121,6 +122,24 @@ stdenv.mkDerivation (finalAttrs: rec { | |||
| "aarch64-darwin" = "osx-arm64"; | |||
| }; | |||
|
|
|||
| updateScript = | |||
| if type != "sdk" then | |||
There was a problem hiding this comment.
Why not add the update script only for type == "sdk" then? This currently prints the warning whenever I try to update GNOME with
nix-shell maintainers/scripts/update.nix --arg predicate '(path: pkg: pkg.updateScript.name or null == "gnome-update-script")'
mdarocha
added a commit
to mdarocha/nixpkgs
that referenced
this pull request
Oct 13, 2022
As per suggestion in NixOS#191962 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
See release notes
Also, in this PR I added an
updateScripttodotnet-sdk, which should (coupled with the previous change to exclude package-specific lockfiles, which avoids having to regenerate all lockfiles) allow all dotnet versions to be updated automatically.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes