fix buildVimPlugin to use pname instead of name

[MangoIV]

Description of changes

Change buildVimPlugin to take pname instead of name

Fixes #193903, documentation has been adjusted. cc @teto

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[MangoIV]

So is this what we want? change the API of the function to take pname and not name?

[lilyball]

We should not ever say version ? "unknown". I'm not aware of any precedent for that, and the use of a word means lib.getName/lib.getVersion when given drv.name will treat the unknown as part of the name.

See #194069 (comment) on the other PR for another approach.

[SuperSandro2000]

Fixed in #194483