python3Packages: Use buildPythonPackage within the package set #194100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reformat, tried to enable tests but we miss a dependency, added pythonImportsCheck. Added top-level attribute to expose executables.
and expose as top-level attribute.
Also enables tests and fixes import check module name.
Build using poetry-core, enabled tests, expose as top-level attribute.
This is a commandline tool, that does not advertise itself as as consumable library, so it does not belong into the python package set. Also fetch from git, so we can enable the tests.
Also some package quality fixes.
and add a top-level attribute.
and expose as top-level attribute.
Does not provide a library interface that could be imported and as such has no place within the python package set.
and expose griffe as top-level attribute.
It's an application with no visible library surface, so it has no place in the python package set.
and add a top-level attribute. The package is broken and needs an updated patch, but that does not mean this change is wrong.
This is a CLI client and not a library and as such it has no place in the python package set.
Was introduced in 2016 with only a top-level attribute, which got removed in the same year, so hasn't been used since. Also last commit in 2013, uses python2 print statements, so it has to go.
and expose as ironicclient top-level attribute.
and enable test suite.
and expose as top-level attribute.
and expose a top-level attribute.
and expose top-level attribute.
SuperSandro2000
approved these changes
Oct 2, 2022
|
Thank you! I noticed also an increasing amount of applications sneaking into the package set. Good to have this cleared out. Note we could add a test in the fix point of |
|
See #194205 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Libraries should be built using
buildPythonPackage. Migrate pure applications out of the python package set, create top-level attributes for others.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes