-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.withings-api: init at 2.4.0 #196312
Conversation
This will not build until the other PR is merged (since that PR is required for the presence of requests-oauth) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please move the home-assistant changes into a separate commit. Check the
git log
forcomponent-packages.nix
for ideas how to name it. - Also use
pkgs/servers/home-assistant/parse_requirements.py
to update the components list, don't do it by hand, because you missed something. 😉
Let's try and drop the postPatch = ''
sed -i '/requests-oauth =/d' pyproject.toml # unused
''; |
a5fefd7
to
8974085
Compare
I did my own solution to this (sorry!) in the newest commits. |
parse-requirements.py |
8974085
to
7a5e45e
Compare
Upstream issue for the pyproject.toml change to remove the unused dependency, entirely obsoleting the hack used and also #196309: vangorra/python_withings_api#90 |
However, workaround is viable, therefore good to merge after review (and as maintainer, will eventually remove when issue resolved?) |
501e810
to
9ba6fe1
Compare
Should be solved (as far as tests are concerned?) hopefully. |
Please squash |
9ba6fe1
to
dc78d19
Compare
Squashed into first commit. |
dc78d19
to
39a1c17
Compare
Made the requested changes! |
Description of changes
It is the packaged python module "withings-api", missing from the Home Assistant Withings component.
It is also added to the list of modules pulled in by the component "withings" for home assistant.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes