Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.withings-api: init at 2.4.0 #196312

Merged
merged 2 commits into from
Oct 16, 2022

Conversation

kittywitch
Copy link
Member

@kittywitch kittywitch commented Oct 16, 2022

Description of changes

It is the packaged python module "withings-api", missing from the Home Assistant Withings component.

It is also added to the list of modules pulled in by the component "withings" for home assistant.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@kittywitch
Copy link
Member Author

This will not build until the other PR is merged (since that PR is required for the presence of requests-oauth)

Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please move the home-assistant changes into a separate commit. Check the git log for component-packages.nix for ideas how to name it.
  • Also use pkgs/servers/home-assistant/parse_requirements.py to update the components list, don't do it by hand, because you missed something. 😉

@mweinelt
Copy link
Member

Let's try and drop the requests-oauth dependency, as I believe it is unused.

  postPatch = ''
    sed -i '/requests-oauth =/d' pyproject.toml # unused
  '';

@kittywitch
Copy link
Member Author

Let's try and drop the requests-oauth dependency, as I believe it is unused.

  postPatch = ''
    sed -i '/requests-oauth =/d' pyproject.toml # unused
  '';

I did my own solution to this (sorry!) in the newest commits.

@kittywitch
Copy link
Member Author

  • pkgs/servers/home-assistant/parse_requirements.py

parse-requirements.py

@kittywitch
Copy link
Member Author

Upstream issue for the pyproject.toml change to remove the unused dependency, entirely obsoleting the hack used and also #196309: vangorra/python_withings_api#90

@kittywitch
Copy link
Member Author

However, workaround is viable, therefore good to merge after review (and as maintainer, will eventually remove when issue resolved?)

@kittywitch
Copy link
Member Author

Should be solved (as far as tests are concerned?) hopefully.

@mweinelt
Copy link
Member

Please squash 9ba6fe1 (#196312) into the first commit.

@kittywitch
Copy link
Member Author

Squashed into first commit.

@kittywitch
Copy link
Member Author

Made the requested changes!

@mweinelt mweinelt merged commit f10c7ab into NixOS:master Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants