Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jekyll-favicon: Add to full Jekyll setup #198601

Merged
merged 1 commit into from
Nov 28, 2022
Merged

jekyll-favicon: Add to full Jekyll setup #198601

merged 1 commit into from
Nov 28, 2022

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented Oct 30, 2022 •
edited
Loading

Description of changes

Include jekyll-favicon when withOptionalDependencies is set.

At-ing other gemset.nix contributors @primeos @raboof @grahamc @anthonyroussel since there's no official maintainer.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: kernel The Linux kernel 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: printing 6.topic: python 6.topic: ruby 6.topic: rust 6.topic: systemd 6.topic: TeX Issues regarding texlive and TeX in general 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 30, 2022
@l0b0 l0b0 changed the base branch from master to staging October 30, 2022 05:24
@github-actions github-actions bot removed 6.topic: systemd 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: rust 8.has: documentation This PR adds or changes documentation 6.topic: printing 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 6.topic: kernel The Linux kernel 6.topic: ruby labels Oct 30, 2022
@l0b0 l0b0 force-pushed the feat/add-jekyll-favicon-to-full-jekyll-setup branch from c917e09 to 10fcf47 Compare November 11, 2022 03:58
@l0b0 l0b0 force-pushed the feat/add-jekyll-favicon-to-full-jekyll-setup branch from 10fcf47 to f4c278c Compare November 24, 2022 02:01
@l0b0 l0b0 marked this pull request as ready for review November 28, 2022 05:37
@anthonyroussel
Copy link
Member

Result of nixpkgs-review pr 198601 run on x86_64-linux 1

2 packages built:
  • jekyll
  • jsonnet

@raboof raboof merged commit 2415d44 into NixOS:staging Nov 28, 2022
SuperSandro2000
SuperSandro2000 reviewed Dec 9, 2022
View reviewed changes
pkgs/applications/misc/jekyll/basic/Gemfile.lock
@@ -101,4 +101,4 @@ DEPENDENCIES
jemoji

BUNDLED WITH
2.3.25
2.3.9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just remove the bundled with section TBH

@l0b0 l0b0 deleted the feat/add-jekyll-favicon-to-full-jekyll-setup branch December 11, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@raboof raboof raboof approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@l0b0 @anthonyroussel @raboof @SuperSandro2000