discordo: init at unstable-2023-04-07

[Arian-D]

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[lilyinstarlight]

This seems to build just fine for me on x86_64-linux (though I did not actually try to run it) and the derivation looks good

[Arian-D]

Just a mini update on this:

• I tested it on aarch64 (non-nixos)
• Updated the commit to a more recent version.

[spikespaz]

What about clipboard support?

Should add them to buildInputs.

[lilyinstarlight]

What about clipboard support?

Should add them to buildInputs.

Adding them to buildInputs won't do anything because they are needed at runtime. We could wrapProgram the main binary in the derivation to always have those in PATH, though

Something like:

buildGoModue rec {
  #stuff...
  nativeBuildInputs = [ makeWrapper ];
  #stuff...
  postInstall = ''
    wrapProgram $out/bin/discordo \
      --prefix PATH : ${lib.makeBinPath [ xsel wl-clipboard ]}
  '';
}

[adamcstephens]

Looks good on darwin, too. This commit is now a month behind upstream.

Result of nixpkgs-review pr 210667 run on aarch64-darwin 1

1 package built:

• discordo

---

Result of nixpkgs-review pr 210667 run on x86_64-darwin 1

1 package built:

• discordo

[lilyinstarlight]

Do you think you could bump this to a newer commit? I think it's probably merge-ready

Also if you want to learn something cool for automating the updates, you can add unstableGitUpdater to the file args and add passthru.updateScript = unstableGitUpdater { }; to the derivation, and then r-ryantm should occasionally pick up updates automatically and you can run the update script manually like nix-shell maintainers/scripts/update.nix --argstr commit true --argstr package discordo

[Arian-D]

I apologize about the delay; for some reason I was not getting notification until the most recent message.

• Per spikespaz's requeset I added xsel and wl-clipboard to the definition
• I added the ldflags per Kranzes' suggestion
• I bumped it up to a more recent version and added the unstable updater. Thank you lilyinstarlight for the guidance and advice

[adamcstephens]

You'll want to update the title of the PR to match the new commit description.

This also builds and runs successfully as a static binary, so I'd suggest adding CGO_ENABLED = 0;

[lilyinstarlight]

• I bumped it up to a more recent version and added the unstable updater. Thank you lilyinstarlight for the guidance and advice

So I think I didn't notice it was a Go module when I said that, you actually need to use nix-update (instead of unstableGitUpdater) so that the vendorHash gets updated too:

  passthru.updateScript = nix-update-script {
    extraArgs = [ "--version=branch" ];
  };