Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.wagtail: init at 4.2 #218587

Merged
merged 9 commits into from
Mar 30, 2023
Merged

python3Packages.wagtail: init at 4.2 #218587

merged 9 commits into from
Mar 30, 2023

Conversation

sephii
Copy link
Contributor

@sephii sephii commented Feb 27, 2023

Description of changes

Add the Wagtail CMS along with its dependencies.

I think tests with Python 3.11 are failing because lxml (a dependency of draftjs_exporter) doesn’t seem to support this version of Python yet. Should I disable the package for Python 3.11?

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Feb 27, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1946

SuperSandro2000
SuperSandro2000 requested changes Mar 15, 2023
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot use python3* in pythonPackages because it mixes python versions.

pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/wagtail/tests.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/azure-mgmt-frontdoor/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/draftjs_exporter/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/draftjs_exporter/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/telepath/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/wagtail-factories/tests.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/wagtail-factories/tests.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/wagtail-localize/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/wagtail-localize/default.nix Outdated Show resolved Hide resolved
@sephii sephii requested a review from SuperSandro2000 March 15, 2023 13:12
SuperSandro2000
SuperSandro2000 reviewed Mar 15, 2023
View reviewed changes
pkgs/development/python-modules/wagtail-factories/tests.nix Outdated
dontBuild = true;
dontInstall = true;

# pythonImportsCheck is not used because it requires a Django app
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move that into the default.nix

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Mar 15, 2023 •
edited
Loading

Should I disable the package for Python 3.11?

If there is no patch available for lxml upstream, please mark it broken or disabled.

@GabrielDougherty
Copy link
Member

I got this error when trying nix run nixpkgs#nixpkgs-review pr 218587

error: Function called without required argument "django_modelcluster" at /home/gabriel/.cache/nixpkgs-review/pr-218587/nixpkgs/pkgs/development/python-modules/wagtail/default.nix:7, did you mean "django-modelcluster"?

@sephii sephii force-pushed the python-wagtail branch 2 times, most recently from f0a61c8 to c92177e Compare March 20, 2023 08:13
@sephii sephii requested a review from SuperSandro2000 March 20, 2023 12:03
@sephii
Copy link
Contributor Author

sephii commented Mar 20, 2023

I ran the tests again and now Python 3.11 tests pass just fine.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2005

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 218587 run on x86_64-linux 1

36 packages built:
  • python310Packages.azure-mgmt-frontdoor
  • python310Packages.azure-mgmt-frontdoor.dist
  • python310Packages.django-pattern-library
  • python310Packages.django-pattern-library.dist
  • python310Packages.draftjs-exporter
  • python310Packages.draftjs-exporter.dist
  • python310Packages.l18n
  • python310Packages.l18n.dist
  • python310Packages.permissionedforms
  • python310Packages.permissionedforms.dist
  • python310Packages.telepath
  • python310Packages.telepath.dist
  • python310Packages.wagtail
  • python310Packages.wagtail-factories
  • python310Packages.wagtail-factories.dist
  • python310Packages.wagtail-localize
  • python310Packages.wagtail-localize.dist
  • python310Packages.wagtail.dist
  • python311Packages.azure-mgmt-frontdoor
  • python311Packages.azure-mgmt-frontdoor.dist
  • python311Packages.django-pattern-library
  • python311Packages.django-pattern-library.dist
  • python311Packages.draftjs-exporter
  • python311Packages.draftjs-exporter.dist
  • python311Packages.l18n
  • python311Packages.l18n.dist
  • python311Packages.permissionedforms
  • python311Packages.permissionedforms.dist
  • python311Packages.telepath
  • python311Packages.telepath.dist
  • python311Packages.wagtail
  • python311Packages.wagtail-factories
  • python311Packages.wagtail-factories.dist
  • python311Packages.wagtail-localize
  • python311Packages.wagtail-localize.dist
  • python311Packages.wagtail.dist

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python310Packages.l18n.dist:

got build log for '/nix/store/szfi84x0yl5601rp8jh7h0liyzajl50h-python3.10-l18n-2021.3-dist' from 'daemon'
When evaluating attribute ‘python310Packages.l18n.dist’:
warning: no-python-tests
Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
Near pkgs/development/python-modules/l18n/default.nix:24:

   |
24 |     description = "Locale internationalization package";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-python-tests.md
warning: unused-argument
Unused argument: django.
Near pkgs/development/python-modules/l18n/default.nix:2:3:

  |
2 | , django
  |   ^

warning: unused-argument
Unused argument: fetchFromGitHub.
Near pkgs/development/python-modules/l18n/default.nix:3:3:

  |
3 | , fetchFromGitHub
  |   ^
python310Packages.l18n:

got build log for '/nix/store/rv0kk47x22v220pnpbx5b5517gwqydk2-python3.10-l18n-2021.3' from 'daemon'
When evaluating attribute ‘python310Packages.l18n’:
warning: no-python-tests
Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
Near pkgs/development/python-modules/l18n/default.nix:24:

   |
24 |     description = "Locale internationalization package";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-python-tests.md
warning: unused-argument
Unused argument: django.
Near pkgs/development/python-modules/l18n/default.nix:2:3:

  |
2 | , django
  |   ^

warning: unused-argument
Unused argument: fetchFromGitHub.
Near pkgs/development/python-modules/l18n/default.nix:3:3:

  |
3 | , fetchFromGitHub
  |   ^
python311Packages.l18n.dist:

got build log for '/nix/store/jxzjiilhaacwx860y64inzjvdvi0s95g-python3.11-l18n-2021.3-dist' from 'daemon'
When evaluating attribute ‘python311Packages.l18n.dist’:
warning: unused-argument
Unused argument: django.
Near pkgs/development/python-modules/l18n/default.nix:2:3:

  |
2 | , django
  |   ^

warning: unused-argument
Unused argument: fetchFromGitHub.
Near pkgs/development/python-modules/l18n/default.nix:3:3:

  |
3 | , fetchFromGitHub
  |   ^
python311Packages.l18n:

got build log for '/nix/store/j4j1i7s43gpvcccnf5skw5v7f4506i8s-python3.11-l18n-2021.3' from 'daemon'
When evaluating attribute ‘python311Packages.l18n’:
warning: unused-argument
Unused argument: django.
Near pkgs/development/python-modules/l18n/default.nix:2:3:

  |
2 | , django
  |   ^

warning: unused-argument
Unused argument: fetchFromGitHub.
Near pkgs/development/python-modules/l18n/default.nix:3:3:

  |
3 | , fetchFromGitHub
  |   ^

@SuperSandro2000 SuperSandro2000 merged commit e3652e0 into NixOS:master Mar 30, 2023
SuperSandro2000 added a commit to SuperSandro2000/nixpkgs that referenced this pull request Mar 30, 2023
@SuperSandro2000
python310Packages.l18n: remove unused inputs, disable tests
cf3327c 
follow up to NixOS#218587
@SuperSandro2000 SuperSandro2000 mentioned this pull request Mar 30, 2023
Merged
12 tasks
@SuperSandro2000
Copy link
Member

#223974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sephii @nixos-discourse @SuperSandro2000 @GabrielDougherty