Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs-studio-plugins.obs-vintage-filter: init at 1.0.0 #228502

Merged
merged 1 commit into from
May 8, 2023

Conversation

flexiondotorg
Copy link
Member

Description of changes

An OBS Studio filter where the source can be set to be black & white or sepia: https://github.com/cg2121/obs-vintage-filter

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • obs-studio-plugins.obs-vintage-filter
 result
├──  lib
│  └──  obs-plugins
│     └──  obs-vintage-filter.so
└──  share
   └──  obs
      └──  obs-plugins
         └──  obs-vintage-filter
            ├──  effects
            │  ├──  black_white.effect
            │  └──  sepia.effect
            └──  locale
               └──  en-US.ini

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 27, 2023
Copy link
Contributor

@Hoverbear Hoverbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work ok for me on x86_64-linux!

image

  programs.obs-studio.enable = true;
  programs.obs-studio.plugins = with pkgs; [
    obs-studio-plugins.obs-vintage-filter
  ];

@mweinelt mweinelt added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 6, 2023
@mweinelt mweinelt merged commit bf1fae7 into NixOS:master May 8, 2023
@flexiondotorg flexiondotorg deleted the obs-vintage-filter branch June 14, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants