Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python310Packages.requests: 2.28.2 -> 2.29.0 #229765

Merged
merged 1 commit into from
May 5, 2023

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented May 3, 2023

Changelog: https://github.com/psf/requests/blob/v2.29.0/HISTORY.md

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member

vcunat commented May 12, 2023

Sigh, this update broke python3Packages.cachecontrol and consequently about a hundred failed builds is reported currently. Log: https://hydra.nixos.org/build/219526843/nixlog/1/tail

/cc #231026
We are (and were) in a period with "breaking changes" disallowed, though honestly python stuff seems often bad in predicting backward (in)compatibility, e.g. I wouldn't expect issues from this upstream changelog.

@mweinelt
Copy link
Member

Patched in 4b94393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants