-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ruby_3_0: unpin openssl_1_1 #229890
ruby_3_0: unpin openssl_1_1 #229890
Conversation
And ruby 2 is already EOL a month ago. we may as well drop it, what a bad timing for 23.05. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, looks like a typo
thanks for catching this
This broke build of /cc #231026 Around a hundred builds are reported as caused by this, currently. |
The patch below seem to fix the build. (The backtrace show that openssl is required by --- a/pkgs/top-level/ruby-packages.nix
+++ b/pkgs/top-level/ruby-packages.nix
@@ -2356,7 +2356,7 @@
version = "2.5.9";
};
nokogiri = {
- dependencies = ["mini_portile2" "racc"];
+ dependencies = ["mini_portile2" "racc" "openssl"];
groups = ["default"];
platforms = [];
source = { |
And indeed https://hydra.nixos.org/build/219355113/nixlog/1:
|
Description of changes
The logic was introduced in a902277, but still pinned ruby 3.0+ to openssl_1_1 (due to typo?). cc @ajs124
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)