Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby_3_0: unpin openssl_1_1 #229890

Merged
merged 1 commit into from
May 6, 2023
Merged

ruby_3_0: unpin openssl_1_1 #229890

merged 1 commit into from
May 6, 2023

Conversation

NickCao
Copy link
Member

@NickCao NickCao commented May 4, 2023

Description of changes

The logic was introduced in a902277, but still pinned ruby 3.0+ to openssl_1_1 (due to typo?). cc @ajs124

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@NickCao
Copy link
Member Author

NickCao commented May 4, 2023

And ruby 2 is already EOL a month ago. we may as well drop it, what a bad timing for 23.05.

Copy link
Member

@ajs124 ajs124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, looks like a typo

thanks for catching this

@mweinelt mweinelt merged commit dee3e56 into NixOS:staging May 6, 2023
@NickCao NickCao deleted the ruby-openssl branch May 7, 2023 04:33
@vcunat
Copy link
Member

vcunat commented May 11, 2023

This broke build of rubyPackages_3_0.nokogiri on all four platforms. Log:
https://hydra.nixos.org/build/219301132/nixlog/1/tail

/cc #231026 Around a hundred builds are reported as caused by this, currently.

@NickCao
Copy link
Member Author

NickCao commented May 11, 2023

The patch below seem to fix the build. (The backtrace show that openssl is required by lib/ruby/3.0.0/net/https.rb, so the root cause could be deep down.

--- a/pkgs/top-level/ruby-packages.nix
+++ b/pkgs/top-level/ruby-packages.nix
@@ -2356,7 +2356,7 @@
     version = "2.5.9";
   };
   nokogiri = {
-    dependencies = ["mini_portile2" "racc"];
+    dependencies = ["mini_portile2" "racc" "openssl"];
     groups = ["default"];
     platforms = [];
     source = {

@NickCao
Copy link
Member Author

NickCao commented May 11, 2023

And indeed lib/ruby/3.0.0/openssl.rb is present before this change.

https://hydra.nixos.org/build/219355113/nixlog/1:

*** Following extensions are not compiled:
openssl:
        Could not be configured. It will not be installed.
        /build/ruby-3.0.6/ext/openssl/extconf.rb:113: OpenSSL >= 1.0.1, < 3.0.0 or LibreSSL >= 2.5.0 is required
        Check ext/openssl/mkmf.log for more details.
*** Fix the problems, then remove these directories and try again if you want.

NickCao added a commit to NickCao/nixpkgs that referenced this pull request May 11, 2023
@NickCao NickCao mentioned this pull request May 11, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants