Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapbox-gl-native: fix build #230970

Merged
merged 1 commit into from
May 10, 2023
Merged

mapbox-gl-native: fix build #230970

merged 1 commit into from
May 10, 2023

Conversation

Thra11
Copy link
Member

@Thra11 Thra11 commented May 9, 2023

Pull request submitted upstream:
mapbox/mapbox-gl-native#16666

Description of changes

Simple patch to fix compilation. Submitted upstream, but use local copy until upstream PR is accepted.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

ZHF: #230712

@Thra11 Thra11 added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label May 9, 2023
@Thra11 Thra11 requested a review from mweinelt May 9, 2023 23:25
@mweinelt mweinelt requested a review from dotlambda May 9, 2023 23:42
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 10, 2023
@Mic92 Mic92 merged commit da78ef5 into NixOS:master May 10, 2023
@Thra11 Thra11 deleted the fix-mapbox-gl-native branch May 10, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants