Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shadowsocks-v2ray-plugin: mark as broken #231507

Merged
merged 1 commit into from
May 12, 2023

Conversation

hmenke
Copy link
Member

@hmenke hmenke commented May 12, 2023

Description of changes

ZHF: #230712

Doesn't build with newer Go version: shadowsocks/v2ray-plugin#292

Default Go is 1.20 now if I saw it correctly but shadowsocks-v2ray-plugin only works when compiled with Go <= 1.17

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@hmenke hmenke added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label May 12, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 12, 2023
@mweinelt mweinelt merged commit 028f97e into NixOS:master May 12, 2023
@hmenke hmenke deleted the shadowsocks-v2ray-plugin-1 branch May 16, 2023 08:13
@kurnevsky
Copy link
Member

It does build and works fine. Only newer version doesn't work, see #219343

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants