Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

truvari: disable some tests on darwin #231598

Merged
merged 1 commit into from
May 15, 2023
Merged

truvari: disable some tests on darwin #231598

merged 1 commit into from
May 15, 2023

Conversation

natsukium
Copy link
Member

@natsukium natsukium commented May 13, 2023 •
edited
Loading

Description of changes

add patches to darwin in order to fix truvari anno grm/trf commands.
The upstream is tracking it here. ACEnglish/truvari#154

ZHF: #230712

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 13, 2023
@natsukium natsukium added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label May 13, 2023
@natsukium natsukium mentioned this pull request May 13, 2023
Merged
12 tasks
@mweinelt
Copy link
Member

Looks like we could apply ACEnglish/truvari@3141655 now.

@natsukium natsukium force-pushed the truvari/disable-tests-darwin branch from 2672023 to 5c93de3 Compare May 14, 2023 07:55
@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels May 14, 2023
@RaitoBezarius
Copy link
Member

Result of nixpkgs-review pr 231598 run on x86_64-darwin 1

2 packages built:
  • truvari
  • truvari.dist

@RaitoBezarius
Copy link
Member

Result of nixpkgs-review pr 231598 run on aarch64-darwin 1

2 packages marked as broken and skipped:
  • truvari
  • truvari.dist

@RaitoBezarius
Copy link
Member

Is this expected to work on aarch64-darwin or is it still broken? If still broken, this is ready to go.

@natsukium natsukium force-pushed the truvari/disable-tests-darwin branch from 5c93de3 to 7edb72d Compare May 15, 2023 01:35
@natsukium
Copy link
Member Author

@RaitoBezarius san, the nixpkgs-review results are correct because the "bwa" on which it depends only supports x86_64.
I submitted a PR for aarch64 support in #231635, but it is out of the scope of the ZHF.

@ofborg ofborg bot added 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 15, 2023
@RaitoBezarius
Copy link
Member

@RaitoBezarius san, the nixpkgs-review results are correct because the "bwa" on which it depends only supports x86_64. I submitted a PR for aarch64 support in #231635, but it is out of the scope of the ZHF.

@natsukium san, thank you for your answer. This is good to go :).

@RaitoBezarius RaitoBezarius merged commit 308ee09 into NixOS:master May 15, 2023
@natsukium natsukium deleted the truvari/disable-tests-darwin branch May 15, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@natsukium @mweinelt @RaitoBezarius @SuperSandro2000