davinci-resolve: 17.4.3 -> 18.1.4 #240549

yuuyins · 2023-06-29T14:56:30Z

Description of changes

See #238026 (comment), #238026 (comment)

Things done

yuuyins · 2023-06-29T16:25:22Z

yuuyins · 2023-06-29T19:21:18Z

of course ofborg won't eval/build nonfree derivations... i will left it at this. if anyone's interested, please, pick it up.

https://github.com/NixOS/nixpkgs/pull/240549/checks?check_run_id=14664185468

OfBorg / davinci-resolve, davinci-resolve.passthru.tests on x86_64-linux

           ];
         }

       c) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
         { allowUnfree = true; }
       to ~/.config/nixpkgs/config.nix.

Cannot nix-instantiate `davinci-resolve.passthru.tests' because:
error: attribute 'tests' in selection path 'davinci-resolve.passthru.tests' not found

yuuyins · 2023-06-29T21:07:34Z

after successful build, there are still missing dependencies/libs like libdbus-1.so.3 so was not able to run

let-env 'NIXPKGS_ALLOW_UNFREE' = 1; nix build --impure '/mnt/pro/dev/org.nixos/nixpkgs/davinci-resolve#davinci-resolve'
[1/19/24 built, 870 copied (2876.4/2879.7 MiB), 641.4 MiB DL] building davinci-resolve-18.1.4 (unpackPhase): unpacking source archive /nix/store/rfxva36fcys7lmmqlmdjh1m6006zmgzy-davinci-reso[[1/19/24 built, 870 copied (2876.4/2879.7 MiB), 641.4 MiB DL] building davinci-resolve-18.1.4 (fixupPhase): shrinking /nix/store/j525zvvzcahpd4pjz62zx3dmwdip4q6g-davinci-resolve-18.1.4/libs[1[1/19/24 built, 870 copied (2876.4/2879.7 [1/19/24 built, 870 copied (2876.4/2879.7 MiB), 641.4 λ yuu @ li-nixos in /mnt/pro/dev/org.nixos/nixpkgs/davinci-resolve

./result/bin/davinci-resolve
/nix/store/j525zvvzcahpd4pjz62zx3dmwdip4q6g-davinci-resolve-18.1.4/bin/resolve: error while loading shared libraries: libdbus-1.so.3: cannot open shared object file: No such file or directory

i just added dbus as dependency, but I'm afraid other dependencies for run-time will be missing as well

We appreciate help to find if any dependency still is missing. That is, help building from scratch to find out (as building davinci-resolve takes some time and uses full computing resources on my current machine, and ofborg won't eval/build nonfree derivations like davinci-resolve)

export NIXPKGS_ALLOW_UNFREE=1
nix build --print-build-logs --impure '/path/to/nixpkgs#davinci-resolve'
...
./result/bin/davinci-resolve

if davinci-resolve still errors with something like error while loading shared libraries: libdbus-1.so.3..., try to e.g. nix-locate libdbus-1.so.3 to find which package has that, and add as dependency just as I did with dbus. Then

unlink result
sudo nix-collect-garbage --delete-old

and redo the

export NIXPKGS_ALLOW_UNFREE=1
nix build --print-build-logs --impure '/path/to/nixpkgs#davinci-resolve'
...
./result/bin/davinci-resolve

#238026 (comment) could give hints on what libraries/dependencies davinci resolve 18.1.4 needs

yuuyins · 2023-06-29T23:14:05Z

Alright, after adding dbus and dependencies from @BKSalman gist https://gist.github.com/BKSalman/53dc4a4bd3eb3989f88ce25b66d82853

it runs

nvidia-offload ./result/bin/davinci-resolve
ActCCMessage Already in Table: Code= c005, Mode= 13, Level=  1, CmdKey= -1, Option= 0
ActCCMessage Already in Table: Code= c006, Mode= 13, Level=  1, CmdKey= -1, Option= 0
ActCCMessage Already in Table: Code= c007, Mode= 13, Level=  1, CmdKey= -1, Option= 0
ActCCMessage Already in Table: Code= 2282, Mode=  0, Level=  0, CmdKey= 8, Option= 0
PnlMsgActionStringAdapter Already in Table: Code= 615e, Mode=  0, Level=  0, CmdKey= -1, Option= 0
log4cxx: No appender could be found for logger (BtCommon).
log4cxx: Please initialize the log4cxx system properly.
QSocketNotifier: Can only be used with threads started with QThread
18.1.4.0009 Linux/Clang x86_64
Main thread starts: 17A19800
log4cxx: setFile(./logs/rollinglog.txt,true) call failed.
log4cxx: IO Exception : status code = 30
0x7f7117a19800 | Undefined            | INFO  | 2023-06-29 17:44:16,032 | --------------------------------------------------------------------------------
log4cxx: No output stream or file set for the appender named [RollLogAppender].
0x7f7117a19800 | Undefined            | INFO  | 2023-06-29 17:44:16,033 | Loaded log config from /home/yuu/.local/share/DaVinciResolve/configs/log-conf.xml
0x7f7117a19800 | Undefined            | INFO  | 2023-06-29 17:44:16,033 | --------------------------------------------------------------------------------
Resolve communication is open and waiting..
Accepted new client
Socket disconnected

Full let-env 'NIXPKGS_ALLOW_UNFREE' = 1; nix build --print-build-logs --impure '/mnt/pro/dev/org.nixos/nixpkgs/davinci-resolve#davinci-resolve' log
davinci.log

nixos-discourse · 2023-06-29T23:17:14Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2377

yuuyins · 2023-06-29T23:18:04Z

@BKSalman @icodeforyou-dot-net @jshcmpbll @davidak

please review

BKSalman · 2023-06-29T23:24:26Z

@BKSalman @icodeforyou-dot-net @jshcmpbll @davidak

please review

Thank you for taking the time and working on this!!

However unfortunately I'm in a vacation right now, and don't have my machine, so I can't review it now, but I think it should be all good as long as you used deps from the gist (since i got it to work on my machine with the gist), and you verified it yourself, maybe the other dear commenters can review it!

Added dependencies according with given Salman Abuhaimed's gist. Resorted dependencies alphabetically. References: - NixOS#238026 (comment) - https://gist.github.com/BKSalman/53dc4a4bd3eb3989f88ce25b66d82853 Co-authored-by: Salman Abuhaimed <85521119+BKSalman@users.noreply.github.com>

yuuyins · 2023-06-29T23:37:05Z

(this last force push was just to add correct Salman Abuhaimed email in Co-authored last commit)

l0b0

I don't know the program, but the PR looks great - alphabetically ordered args, long flags, Python 3. 👍

yuuyins · 2023-06-30T02:23:42Z

Just a notice for anyone who might want to try testing: MP4s do not work on DR Linux free version https://wiki.archlinux.org/title/DaVinci_Resolve#Mp4_clips_are_not_working

needs to convert to MOV as usual for working with video files

ffmpeg -i input.mp4 -c:v dnxhd -profile:v dnxhr_hq -pix_fmt yuv422p -c:a pcm_s16le -f mov output.mov

and if using pipewire, needs to enable alsa for audio to work e.g.

{
  services.pipewire = {
    enable = true;

    alsa = {
      enable = true;
      support32Bit = true;
    };
   
    pulse.enable = true;

    wireplumber.enable = true;
  };
}

then

systemctl --user restart pipewire pipewire-pulse wireplumber

restart davinci-resolve, and audio should work

ic4-y · 2023-06-30T06:59:02Z

@yuuyins thanks for your work, 🚀

I just came back to my computer to see you've been working relentlessly on this the past couple of hours! 😄

davidak · 2023-06-30T11:26:13Z

Result of nixpkgs-review pr 240549 run on x86_64-linux 1

1 package built:

davinci-resolve

davidak

Change looks good

Builds, runs

AMD GPU with OpenCL detected

Can someone test a Nvidia GPU with CUDA?

No issue found with function

Tested:

Create a new project
Load existing projects
Playback project timeline
Cut video
Apply color correction
Apply effects
Apply transition
Render projects

Thanks for your efforts! ✨

yuuyins · 2023-07-01T00:08:29Z

@davidak with nvidia offload, tested with nvidia cuda

tested:

Create a new project
Load existing projects
Playback project timeline
Cut video
Apply color correction
Apply effects
Fusion
Color
Fairlight
Render projects

nixos-discourse · 2023-07-02T00:26:12Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1008

jshcmpbll

@BKSalman Nice find on dbus. I was trying update this myself and was hitting a lot of issues.

Nice work @yuuyins 🥳 Would love help maintaining it if anyone is interested too - im still trying (albeit slowly) to make the derivation build the studio and beta versions too

SuperSandro2000 · 2023-07-02T00:40:49Z

pkgs/applications/video/davinci-resolve/default.nix

+      buildInputs = [
+        libGLU
+        xorg.libXxf86vm
+      ];

      src = runCommandLocal "${pname}-src.zip"
        rec {
          outputHashMode = "recursive";
          outputHashAlgo = "sha256";


Suggested change

outputHashAlgo = "sha256";

pbsds · 2023-07-02T09:59:42Z

Considering davinci refuses to evaluate on 23.05 due to the python2 dep, i believe a backport can be considered a non-breaking change.

BKSalman · 2023-07-03T19:04:51Z

Thanks for your work @yuuyins and everyone!

SimonBrandner · 2023-08-24T12:53:45Z

Could someone please add the backport release-23.05 label?

pbsds · 2023-08-24T15:24:02Z

I'm much in favor, but won't be the one to call the shot.

yuuyins force-pushed the davinci-resolve branch 3 times, most recently from c053605 to 095bca1 Compare June 29, 2023 15:46

yuuyins marked this pull request as ready for review June 29, 2023 16:18

yuuyins marked this pull request as draft June 29, 2023 16:25

ofborg bot requested a review from jshcmpbll June 29, 2023 16:31

ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 29, 2023

yuuyins force-pushed the davinci-resolve branch from 095bca1 to 0c3165a Compare June 29, 2023 21:01

yuuyins mentioned this pull request Jun 29, 2023

Update request: davinci-resolve 17.4.3 → 18.1.4 #238026

Closed

1 task

davinci-resolve: 17.4.3 -> 18.1.4

c4319ac

yuuyins force-pushed the davinci-resolve branch from 0c3165a to 9086541 Compare June 29, 2023 23:05

yuuyins marked this pull request as ready for review June 29, 2023 23:14

mweinelt requested a review from davidak June 29, 2023 23:21

yuuyins force-pushed the davinci-resolve branch from 9086541 to e0d25a0 Compare June 29, 2023 23:36

l0b0 approved these changes Jun 29, 2023

View reviewed changes

davidak approved these changes Jun 30, 2023

View reviewed changes

figsoda added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jul 1, 2023

jshcmpbll approved these changes Jul 2, 2023

View reviewed changes

SuperSandro2000 reviewed Jul 2, 2023

View reviewed changes

SuperSandro2000 merged commit 3eb8ccf into NixOS:master Jul 2, 2023

This was referenced Jul 2, 2023

davinci-resolve: .desktop file missing #166900

Closed

error: Package ‘python-2.7.18.6’ in cpython/2.7/default.nix:341 is marked as insecure, refusing to evaluate. #210098

Closed

pbsds added backport release-23.05 and removed backport release-23.05 labels Aug 24, 2023

davidak mentioned this pull request Sep 4, 2023

[23.05] Backport fixes for davinci-resolve #253230

Closed

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

davinci-resolve: 17.4.3 -> 18.1.4 #240549

davinci-resolve: 17.4.3 -> 18.1.4 #240549

yuuyins commented Jun 29, 2023 •

edited

Loading

yuuyins commented Jun 29, 2023

yuuyins commented Jun 29, 2023

yuuyins commented Jun 29, 2023 •

edited

Loading

yuuyins commented Jun 29, 2023

nixos-discourse commented Jun 29, 2023

yuuyins commented Jun 29, 2023

BKSalman commented Jun 29, 2023 •

edited

Loading

yuuyins commented Jun 29, 2023 •

edited

Loading

l0b0 left a comment

yuuyins commented Jun 30, 2023 •

edited

Loading

ic4-y commented Jun 30, 2023 •

edited

Loading

davidak commented Jun 30, 2023

davidak left a comment •

edited

Loading

yuuyins commented Jul 1, 2023

nixos-discourse commented Jul 2, 2023

jshcmpbll left a comment

SuperSandro2000 Jul 2, 2023

pbsds commented Jul 2, 2023 •

edited

Loading

BKSalman commented Jul 3, 2023

SimonBrandner commented Aug 24, 2023

pbsds commented Aug 24, 2023

davinci-resolve: 17.4.3 -> 18.1.4 #240549

davinci-resolve: 17.4.3 -> 18.1.4 #240549

Conversation

yuuyins commented Jun 29, 2023 • edited Loading

Description of changes

Things done

yuuyins commented Jun 29, 2023

yuuyins commented Jun 29, 2023

yuuyins commented Jun 29, 2023 • edited Loading

yuuyins commented Jun 29, 2023

nixos-discourse commented Jun 29, 2023

yuuyins commented Jun 29, 2023

BKSalman commented Jun 29, 2023 • edited Loading

yuuyins commented Jun 29, 2023 • edited Loading

l0b0 left a comment

Choose a reason for hiding this comment

yuuyins commented Jun 30, 2023 • edited Loading

ic4-y commented Jun 30, 2023 • edited Loading

davidak commented Jun 30, 2023

davidak left a comment • edited Loading

Choose a reason for hiding this comment

yuuyins commented Jul 1, 2023

nixos-discourse commented Jul 2, 2023

jshcmpbll left a comment

Choose a reason for hiding this comment

SuperSandro2000 Jul 2, 2023

Choose a reason for hiding this comment

pbsds commented Jul 2, 2023 • edited Loading

BKSalman commented Jul 3, 2023

SimonBrandner commented Aug 24, 2023

pbsds commented Aug 24, 2023

yuuyins commented Jun 29, 2023 •

edited

Loading

yuuyins commented Jun 29, 2023 •

edited

Loading

BKSalman commented Jun 29, 2023 •

edited

Loading

yuuyins commented Jun 29, 2023 •

edited

Loading

yuuyins commented Jun 30, 2023 •

edited

Loading

ic4-y commented Jun 30, 2023 •

edited

Loading

davidak left a comment •

edited

Loading

pbsds commented Jul 2, 2023 •

edited

Loading