Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liana: init at 2.0 #252917

Merged
merged 2 commits into from
Sep 9, 2023
Merged

liana: init at 2.0 #252917

merged 2 commits into from
Sep 9, 2023

Conversation

dunxen
Copy link
Contributor

@dunxen dunxen commented Sep 2, 2023

Liana is a simple Bitcoin wallet that features a timelocked recovery path for all your coins.

Homepage: https://wizardsardine.com/liana
GitHub Repo: https://github.com/wizardsardine/liana
Announcement: https://youtu.be/KN6Cj2-eX_Q?si=HovGsk5fFKtLFxeF&t=84

See release notes for v2.0 at:
https://github.com/wizardsardine/liana/releases/tag/v2.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Sep 2, 2023
@nagy
Copy link
Member

nagy commented Sep 2, 2023

Thanks. The part in maintainer-list.nix needs to be in a separate commit. You can find good examples for the commit message in the history of that file https://github.com/NixOS/nixpkgs/commits/master/maintainers/maintainer-list.nix

pkgs/applications/blockchains/liana/default.nix Outdated Show resolved Hide resolved
pkgs/applications/blockchains/liana/default.nix Outdated Show resolved Hide resolved
pkgs/applications/blockchains/liana/default.nix Outdated Show resolved Hide resolved
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 6, 2023
@dunxen dunxen changed the title liana: init at 1.1 liana: init at 2.0 Sep 8, 2023
@dunxen
Copy link
Contributor Author

dunxen commented Sep 8, 2023

2.0 was just released so updated to that and added Cargo.lock as it appears at tag v2.0

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 8, 2023
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 8, 2023
Liana is a simple Bitcoin wallet that features a timelocked recovery
path for all your coins.

See release notes at:
https://github.com/wizardsardine/liana/releases/tag/v2.0
@wegank wegank merged commit 757ba80 into NixOS:master Sep 9, 2023
10 checks passed
@dunxen dunxen deleted the add-liana-package branch September 9, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants